[GitHub] flink pull request #3377: [FLINK-5645] Store accumulators/metrics for cancel...

[uce <gi...@git.apache.org>]

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3377#discussion_r104394092
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java ---
    @@ -1311,6 +1311,19 @@ public boolean updateState(TaskExecutionState state) {
     		}
     	}
     
    +	private Map<String, Accumulator<?, ?>> deserializeAccumulators(TaskExecutionState state) {
    --- End diff --
    
    I've checked that returning `null` is the same behaviour as in `accumulators.deserializeUserAccumulators(userClassLoader)`. In general it would be good to add annotations for `@Nullable` return types or simply return empty collections, but that's an orthogonal change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---