You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/07/19 09:03:47 UTC

Review Request 60958: Made the metrics::Timer time window argument compulsory.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60958/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Kevin Klues, and Jiang Yan Xu.


Bugs: MESOS-6918
    https://issues.apache.org/jira/browse/MESOS-6918


Repository: mesos


Description
-------

If Timer metrics don't have a time window, then just store the last
sampled duration. Since you can't meaningfully graph this (you don't
know when it changed), make the time window compulsory so that we
can always calculate TimeWindow statistics.


Diffs
-----

  3rdparty/libprocess/include/process/metrics/timer.hpp 0a9c0227c457c6c81a59f65f901a5464ee00983d 


Diff: https://reviews.apache.org/r/60958/diff/1/


Testing
-------

make check


Thanks,

James Peach