You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/04/12 09:32:26 UTC
[GitHub] [cloudstack] fdalsotto commented on a change in pull request #4907: vmware: Add force parameter to iso attach/detach operations
fdalsotto commented on a change in pull request #4907:
URL: https://github.com/apache/cloudstack/pull/4907#discussion_r611472936
##########
File path: api/src/main/java/com/cloud/template/TemplateApiService.java
##########
@@ -56,9 +56,9 @@
VirtualMachineTemplate prepareTemplate(long templateId, long zoneId, Long storageId);
- boolean detachIso(long vmId);
+ boolean detachIso(long vmId, boolean forced);
Review comment:
can we define a default value for these boolean variables? this way you can avoid doing `forced != null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org