You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/07 22:33:43 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4088: In
TimeUtils.timeUnitFromString(), return null if input is null or empty
codecov-io commented on issue #4088: In TimeUtils.timeUnitFromString(), return null if input is null or empty
URL: https://github.com/apache/incubator-pinot/pull/4088#issuecomment-480635690
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4088?src=pr&el=h1) Report
> Merging [#4088](https://codecov.io/gh/apache/incubator-pinot/pull/4088?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/af62e202ddffbdf8d0e39213631a5ff429d1af13?src=pr&el=desc) will **increase** coverage by `6.78%`.
> The diff coverage is `75%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4088?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4088 +/- ##
===========================================
+ Coverage 59.91% 66.7% +6.78%
Complexity 20 20
===========================================
Files 1158 1035 -123
Lines 58332 51376 -6956
Branches 8101 7189 -912
===========================================
- Hits 34952 34268 -684
+ Misses 20947 14754 -6193
+ Partials 2433 2354 -79
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4088?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../pinot/core/segment/index/SegmentMetadataImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4088/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L1NlZ21lbnRNZXRhZGF0YUltcGwuamF2YQ==) | `81.32% <0%> (-0.69%)` | `0 <0> (ø)` | |
| [...n/config/SegmentsValidationAndRetentionConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4088/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1NlZ21lbnRzVmFsaWRhdGlvbkFuZFJldGVudGlvbkNvbmZpZy5qYXZh) | `48.23% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/pinot/common/utils/time/TimeUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4088/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvdGltZS9UaW1lVXRpbHMuamF2YQ==) | `89.18% <100%> (+3.47%)` | `0 <0> (ø)` | :arrow_down: |
| [...r/validation/RealtimeSegmentValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4088/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1JlYWx0aW1lU2VnbWVudFZhbGlkYXRpb25NYW5hZ2VyLmphdmE=) | `43.33% <0%> (-11.67%)` | `0% <0%> (ø)` | |
| [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4088/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `88.88% <0%> (-6.67%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4088/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `86.66% <0%> (-6.67%)` | `0% <0%> (ø)` | |
| [...e/operator/dociditerators/SortedDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4088/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9Tb3J0ZWREb2NJZEl0ZXJhdG9yLmphdmE=) | `55.55% <0%> (-5.56%)` | `0% <0%> (ø)` | |
| [...e/operator/dociditerators/SVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4088/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9TVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=) | `65.47% <0%> (-2.39%)` | `0% <0%> (ø)` | |
| [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/4088/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `26.43% <0%> (-2.3%)` | `0% <0%> (ø)` | |
| [...l/FixedByteSingleColumnMultiValueReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4088/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXJ3cml0ZXIvaW1wbC9GaXhlZEJ5dGVTaW5nbGVDb2x1bW5NdWx0aVZhbHVlUmVhZGVyV3JpdGVyLmphdmE=) | `68.91% <0%> (-2.08%)` | `0% <0%> (ø)` | |
| ... and [145 more](https://codecov.io/gh/apache/incubator-pinot/pull/4088/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4088?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4088?src=pr&el=footer). Last update [af62e20...9694387](https://codecov.io/gh/apache/incubator-pinot/pull/4088?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org