You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2016/01/06 11:28:21 UTC
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 10:28 a.m.)
Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
Bugs: MESOS-2317
https://issues.apache.org/jira/browse/MESOS-2317
Repository: mesos
Description (updated)
-------
Removed slave checkpointing logic after deprecation cycle.
Diffs (updated)
-----
include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678
src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41649/diff/
Testing (updated)
-------
make check
Thanks,
Joerg Schad
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/#review113070
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41649]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 6, 2016, 10:28 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 10:28 a.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2317
> https://issues.apache.org/jira/browse/MESOS-2317
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed slave checkpointing logic after deprecation cycle.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
> src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
> src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
> src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
> src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
> src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678
> src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
> src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
> src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
>
> Diff: https://reviews.apache.org/r/41649/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/#review113457
-----------------------------------------------------------
Ship it!
lgtm!
src/master/master.cpp (line 1076)
<https://reviews.apache.org/r/41649/#comment174179>
Intentional blank?
src/slave/containerizer/containerizer.hpp (line 138)
<https://reviews.apache.org/r/41649/#comment174181>
So this was an error as the checkpoint flag is passed on from the frameworkInfo as discussed.
- Till Toenshoff
On Jan. 7, 2016, 5:13 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 5:13 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2317
> https://issues.apache.org/jira/browse/MESOS-2317
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed slave checkpointing logic after deprecation cycle.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
> src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
> src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
> src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
> src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
> src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678
> src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
> src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
> src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee
> src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
> src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
> src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
>
> Diff: https://reviews.apache.org/r/41649/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Jan. 9, 2016, 12:06 a.m., Adam B wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 284
> > <https://reviews.apache.org/r/41649/diff/6/?file=1187444#file1187444line284>
> >
> > The hierarchicalDRF allocator shouldn't care about the framework's checkpointing state anymore, now that it's not comparing it against the slave's checkpoint variable to filter.
Good catch!
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/#review113556
-----------------------------------------------------------
On Jan. 11, 2016, 10:07 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 10:07 a.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2317
> https://issues.apache.org/jira/browse/MESOS-2317
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed slave checkpointing logic after deprecation cycle.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
> src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
> src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
> src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
> src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
> src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678
> src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
> src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
> src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee
> src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
> src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
> src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
>
> Diff: https://reviews.apache.org/r/41649/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/#review113556
-----------------------------------------------------------
Ship it!
Besides these two minor suggestions, I think this is commit-worthy.
src/master/allocator/mesos/hierarchical.hpp (line 284)
<https://reviews.apache.org/r/41649/#comment174292>
The hierarchicalDRF allocator shouldn't care about the framework's checkpointing state anymore, now that it's not comparing it against the slave's checkpoint variable to filter.
src/master/master.cpp (line 1110)
<https://reviews.apache.org/r/41649/#comment174290>
s/checkpointing//
- Adam B
On Jan. 8, 2016, 4:46 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 4:46 a.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2317
> https://issues.apache.org/jira/browse/MESOS-2317
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed slave checkpointing logic after deprecation cycle.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
> src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
> src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
> src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
> src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
> src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678
> src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
> src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
> src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee
> src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
> src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
> src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
>
> Diff: https://reviews.apache.org/r/41649/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/#review113483
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41649]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 8, 2016, 12:46 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 12:46 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2317
> https://issues.apache.org/jira/browse/MESOS-2317
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed slave checkpointing logic after deprecation cycle.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
> src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
> src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
> src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
> src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
> src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678
> src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
> src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
> src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee
> src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
> src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
> src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
>
> Diff: https://reviews.apache.org/r/41649/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Jan. 8, 2016, 10:12 p.m., Adam B wrote:
> > src/internal/devolve.cpp, line 70
> > <https://reviews.apache.org/r/41649/diff/6/?file=1187443#file1187443line70>
> >
> > BUG? Wouldn't you still need to `set_checkpoint(true)`, since the SlaveInfo.checkpoint protobuf defaults to false, and AgentInfo doesn't have 'checkpoint'?
Also left ```info.set_checkpoint(true);``` in Slave::initialize
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/#review113532
-----------------------------------------------------------
On Jan. 11, 2016, 10:07 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 10:07 a.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2317
> https://issues.apache.org/jira/browse/MESOS-2317
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed slave checkpointing logic after deprecation cycle.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
> src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
> src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
> src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
> src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
> src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678
> src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
> src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
> src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee
> src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
> src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
> src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
>
> Diff: https://reviews.apache.org/r/41649/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/#review113532
-----------------------------------------------------------
Looks pretty good to me except for the potential bug in devolve (although I don't think we even use SlaveInfo.checkpoint for anything anymore). I still want to do a pass over the code to see if there's anything else we ought to remove.
src/internal/devolve.cpp
<https://reviews.apache.org/r/41649/#comment174270>
BUG? Wouldn't you still need to `set_checkpoint(true)`, since the SlaveInfo.checkpoint protobuf defaults to false, and AgentInfo doesn't have 'checkpoint'?
src/master/master.cpp (lines 1073 - 1075)
<https://reviews.apache.org/r/41649/#comment174271>
"The semantics when a registered slave gets disconnected are as follows for each framework running on that slave:"
Actually, this whole comment block probably makes more sense above the foreach(frameworkIds) loop, where that "Remove all non-checkpointing frameworks" comment lives now
src/master/master.cpp (line 1088)
<https://reviews.apache.org/r/41649/#comment174272>
Unnecessary comment?
- Adam B
On Jan. 8, 2016, 4:46 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 4:46 a.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2317
> https://issues.apache.org/jira/browse/MESOS-2317
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed slave checkpointing logic after deprecation cycle.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
> src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
> src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
> src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
> src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
> src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678
> src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
> src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
> src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee
> src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
> src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
> src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
>
> Diff: https://reviews.apache.org/r/41649/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/#review113962
-----------------------------------------------------------
I thought we said we'd leave info.set_checkpoint(true); in the devolve() call?
I also noticed some comments still referencing "checkpointing slave" (`grep -rin "checkpointing slave" src/`).
src/master/allocator/mesos/hierarchical.cpp (lines 377 - 378)
<https://reviews.apache.org/r/41649/#comment174743>
re-wrap
src/examples/docker_no_executor_framework.cpp (line 184)
<https://reviews.apache.org/r/41649/#comment174744>
Remove the double-blank line.
src/internal/devolve.cpp
<https://reviews.apache.org/r/41649/#comment174745>
I thought we said we'd leave this `info.set_checkpoint(true);` in?
- Adam B
On Jan. 11, 2016, 2:07 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 2:07 a.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2317
> https://issues.apache.org/jira/browse/MESOS-2317
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed slave checkpointing logic after deprecation cycle.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
> src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
> src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
> src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
> src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
> src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678
> src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
> src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
> src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee
> src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
> src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
> src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
>
> Diff: https://reviews.apache.org/r/41649/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/#review114067
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41649]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 12, 2016, 3:01 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 3:01 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2317
> https://issues.apache.org/jira/browse/MESOS-2317
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed slave checkpointing logic after deprecation cycle.
>
>
> Diffs
> -----
>
> docs/configuration.md cbe7f5a338a0fc350c4b6c0e2f1f48bd0869ac34
> docs/slave-recovery.md 73b837278f928511b17d9dbf30286f7b1eb4ce29
> include/mesos/mesos.proto 74e9d00d6826adfb7fd2433c3deced6d2ca51e98
> src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
> src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
> src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
> src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
> src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
> src/master/master.cpp 5268408fc63a28afabc27cba96d3ecb360608a65
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
> src/slave/flags.cpp 19c2996c4572b992030f8824380f3979ced7e526
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
> src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
> src/tests/master_authorization_tests.cpp 3e14f63604b93a7f4ad9cb2b916747d958056559
> src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
> src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6
>
> Diff: https://reviews.apache.org/r/41649/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/#review114097
-----------------------------------------------------------
Ship it!
Looks great! Only a handful of minor doc/comment changes. I'll make these myself and commit it.
src/internal/devolve.cpp
<https://reviews.apache.org/r/41649/#comment174892>
s/v1:;/v1::/
docs/configuration.md (line 1444)
<https://reviews.apache.org/r/41649/#comment174890>
Not yours, but where is the opening `(`?
I'd suggest s/upgrade!)./upgrade./
docs/configuration.md (line 1445)
<https://reviews.apache.org/r/41649/#comment174889>
Can remove this paragraph break now.
docs/configuration.md (line 1454)
<https://reviews.apache.org/r/41649/#comment174904>
Not yours, but s/alloted/allotted/
docs/configuration.md (line 1457)
<https://reviews.apache.org/r/41649/#comment174891>
Remove this paragraph break
docs/slave-recovery.md (line 16)
<https://reviews.apache.org/r/41649/#comment174905>
Your parenthesized pluralities are awkward and the parenthesized subject doesn't match the parenthesized verb. To correct this, I would recommend rewording as follows:
s/the framework(s) enable(s)/a framework enables/
- Adam B
On Jan. 12, 2016, 7:01 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 7:01 a.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2317
> https://issues.apache.org/jira/browse/MESOS-2317
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed slave checkpointing logic after deprecation cycle.
>
>
> Diffs
> -----
>
> docs/configuration.md cbe7f5a338a0fc350c4b6c0e2f1f48bd0869ac34
> docs/slave-recovery.md 73b837278f928511b17d9dbf30286f7b1eb4ce29
> include/mesos/mesos.proto 74e9d00d6826adfb7fd2433c3deced6d2ca51e98
> src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
> src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
> src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
> src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
> src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
> src/master/master.cpp 5268408fc63a28afabc27cba96d3ecb360608a65
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
> src/slave/flags.cpp 19c2996c4572b992030f8824380f3979ced7e526
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
> src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
> src/tests/master_authorization_tests.cpp 3e14f63604b93a7f4ad9cb2b916747d958056559
> src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
> src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6
>
> Diff: https://reviews.apache.org/r/41649/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 3:01 p.m.)
Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
Changes
-------
Rebased.
Bugs: MESOS-2317
https://issues.apache.org/jira/browse/MESOS-2317
Repository: mesos
Description
-------
Removed slave checkpointing logic after deprecation cycle.
Diffs (updated)
-----
docs/configuration.md cbe7f5a338a0fc350c4b6c0e2f1f48bd0869ac34
docs/slave-recovery.md 73b837278f928511b17d9dbf30286f7b1eb4ce29
include/mesos/mesos.proto 74e9d00d6826adfb7fd2433c3deced6d2ca51e98
src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
src/master/master.cpp 5268408fc63a28afabc27cba96d3ecb360608a65
src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
src/slave/flags.cpp 19c2996c4572b992030f8824380f3979ced7e526
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
src/tests/master_authorization_tests.cpp 3e14f63604b93a7f4ad9cb2b916747d958056559
src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6
Diff: https://reviews.apache.org/r/41649/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/#review113994
-----------------------------------------------------------
Bad patch!
Reviews applied: [41649]
Failed command: ./support/apply-review.sh -n -r 41649
Error:
2016-01-12 14:56:18 URL:https://reviews.apache.org/r/41649/diff/raw/ [23747/23747] -> "41649.patch" [1]
error: patch failed: docs/configuration.md:1422
error: docs/configuration.md: patch does not apply
- Mesos ReviewBot
On Jan. 12, 2016, 9:56 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 9:56 a.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2317
> https://issues.apache.org/jira/browse/MESOS-2317
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed slave checkpointing logic after deprecation cycle.
>
>
> Diffs
> -----
>
> docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d
> docs/slave-recovery.md 73b837278f928511b17d9dbf30286f7b1eb4ce29
> include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
> src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
> src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
> src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
> src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
> src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
> src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
> src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee
> src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
> src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
> src/tests/master_authorization_tests.cpp 3e14f63604b93a7f4ad9cb2b916747d958056559
> src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
> src/tests/slave_tests.cpp 77750eda99184c0bf4404df8468461e3c7f8cde0
>
> Diff: https://reviews.apache.org/r/41649/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 9:56 a.m.)
Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
Changes
-------
Removed references from documentation.
Bugs: MESOS-2317
https://issues.apache.org/jira/browse/MESOS-2317
Repository: mesos
Description
-------
Removed slave checkpointing logic after deprecation cycle.
Diffs (updated)
-----
docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d
docs/slave-recovery.md 73b837278f928511b17d9dbf30286f7b1eb4ce29
include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
src/tests/master_authorization_tests.cpp 3e14f63604b93a7f4ad9cb2b916747d958056559
src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
src/tests/slave_tests.cpp 77750eda99184c0bf4404df8468461e3c7f8cde0
Diff: https://reviews.apache.org/r/41649/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/#review113779
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41649]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 11, 2016, 10:07 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 10:07 a.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2317
> https://issues.apache.org/jira/browse/MESOS-2317
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed slave checkpointing logic after deprecation cycle.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
> src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
> src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
> src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
> src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
> src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678
> src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
> src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
> src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee
> src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
> src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
> src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
>
> Diff: https://reviews.apache.org/r/41649/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 10:07 a.m.)
Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
Bugs: MESOS-2317
https://issues.apache.org/jira/browse/MESOS-2317
Repository: mesos
Description
-------
Removed slave checkpointing logic after deprecation cycle.
Diffs (updated)
-----
include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678
src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
Diff: https://reviews.apache.org/r/41649/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/
-----------------------------------------------------------
(Updated Jan. 8, 2016, 12:46 p.m.)
Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
Changes
-------
Removed blank line.
Bugs: MESOS-2317
https://issues.apache.org/jira/browse/MESOS-2317
Repository: mesos
Description
-------
Removed slave checkpointing logic after deprecation cycle.
Diffs (updated)
-----
include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678
src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
Diff: https://reviews.apache.org/r/41649/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/#review113279
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41649]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 7, 2016, 5:13 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 5:13 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2317
> https://issues.apache.org/jira/browse/MESOS-2317
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed slave checkpointing logic after deprecation cycle.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
> src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
> src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
> src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
> src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
> src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678
> src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
> src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
> src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
> src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
> src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee
> src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
> src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
> src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
>
> Diff: https://reviews.apache.org/r/41649/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 41649: Removed slave checkpointing logic after
deprecation cycle.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/
-----------------------------------------------------------
(Updated Jan. 7, 2016, 5:13 p.m.)
Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
Changes
-------
Changed some comments.
Bugs: MESOS-2317
https://issues.apache.org/jira/browse/MESOS-2317
Repository: mesos
Description
-------
Removed slave checkpointing logic after deprecation cycle.
Diffs (updated)
-----
include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67
src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba
src/examples/docker_no_executor_framework.cpp 7b3f0581f75105addb388dc15c4a0390ae4e0e0e
src/examples/java/TestFramework.java cbcdeedb0da22f82e274d088eb15a4128fd920fe
src/examples/python/test_framework.py 6af6d22f54c0ad702917d09cf658e70f7032d793
src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678
src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08
src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305
src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc
src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
Diff: https://reviews.apache.org/r/41649/diff/
Testing
-------
make check
Thanks,
Joerg Schad