You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2022/03/25 17:59:23 UTC

[Impala-ASF-CR] IMPALA-11203: Fix build failure due to missing imports

Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18355


Change subject: IMPALA-11203: Fix build failure due to missing imports
......................................................................

IMPALA-11203: Fix build failure due to missing imports

This commit puts back ExecutorMembershipSnapshot and AnalysisException
imports into the Frontend class to fix the build failure.

Testing:
 - Ran a clean build.

Change-Id: I726748bd39936a1ddc4831c3a1e0489bd6a164f7
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/18355/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I726748bd39936a1ddc4831c3a1e0489bd6a164f7
Gerrit-Change-Number: 18355
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11203: Fix build failure due to missing imports

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18355 )

Change subject: IMPALA-11203: Fix build failure due to missing imports
......................................................................


Patch Set 1:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7969/


-- 
To view, visit http://gerrit.cloudera.org:8080/18355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I726748bd39936a1ddc4831c3a1e0489bd6a164f7
Gerrit-Change-Number: 18355
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 26 Mar 2022 03:15:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11203: Fix build failure due to missing imports

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18355 )

Change subject: IMPALA-11203: Fix build failure due to missing imports
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7969/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I726748bd39936a1ddc4831c3a1e0489bd6a164f7
Gerrit-Change-Number: 18355
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 22:43:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11203: Fix build failure due to missing imports

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18355 )

Change subject: IMPALA-11203: Fix build failure due to missing imports
......................................................................


Patch Set 1: Code-Review+2

Thanks for fixing this!


-- 
To view, visit http://gerrit.cloudera.org:8080/18355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I726748bd39936a1ddc4831c3a1e0489bd6a164f7
Gerrit-Change-Number: 18355
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 18:08:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11203: Fix build failure due to missing imports

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18355 )

Change subject: IMPALA-11203: Fix build failure due to missing imports
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7968/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I726748bd39936a1ddc4831c3a1e0489bd6a164f7
Gerrit-Change-Number: 18355
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 18:09:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11203: Fix build failure due to missing imports

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18355 )

Change subject: IMPALA-11203: Fix build failure due to missing imports
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7968/


-- 
To view, visit http://gerrit.cloudera.org:8080/18355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I726748bd39936a1ddc4831c3a1e0489bd6a164f7
Gerrit-Change-Number: 18355
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 22:33:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11203: Fix build failure due to missing imports

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18355 )

Change subject: IMPALA-11203: Fix build failure due to missing imports
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10337/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I726748bd39936a1ddc4831c3a1e0489bd6a164f7
Gerrit-Change-Number: 18355
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 18:19:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11203: Fix build failure due to missing imports

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18355 )

Change subject: IMPALA-11203: Fix build failure due to missing imports
......................................................................

IMPALA-11203: Fix build failure due to missing imports

This commit puts back ExecutorMembershipSnapshot and AnalysisException
imports into the Frontend class to fix the build failure.

Testing:
 - Ran a clean build.

Change-Id: I726748bd39936a1ddc4831c3a1e0489bd6a164f7
Reviewed-on: http://gerrit.cloudera.org:8080/18355
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Zoltan Borok-Nagy: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I726748bd39936a1ddc4831c3a1e0489bd6a164f7
Gerrit-Change-Number: 18355
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11203: Fix build failure due to missing imports

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18355 )

Change subject: IMPALA-11203: Fix build failure due to missing imports
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I726748bd39936a1ddc4831c3a1e0489bd6a164f7
Gerrit-Change-Number: 18355
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 26 Mar 2022 13:53:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11203: Fix build failure due to missing imports

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18355 )

Change subject: IMPALA-11203: Fix build failure due to missing imports
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7970/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I726748bd39936a1ddc4831c3a1e0489bd6a164f7
Gerrit-Change-Number: 18355
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 26 Mar 2022 09:30:59 +0000
Gerrit-HasComments: No