[GitHub] [iceberg] jackye1995 commented on a diff in pull request #5644: AWS: Add s3.dualstack-enabled flag to AwsProperties

[GitBox <gi...@apache.org>]

jackye1995 commented on code in PR #5644:
URL: https://github.com/apache/iceberg/pull/5644#discussion_r956469108


##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -105,6 +106,7 @@ public S3Client s3() {
       return S3Client.builder()
           .httpClientBuilder(configureHttpClientBuilder(httpClientType))
           .applyMutation(builder -> configureEndpoint(builder, s3Endpoint))
+          .dualstackEnabled(s3DualStackEnabled)

Review Comment:
   oh interesting, I did not know dual stack is a feature common to all AWS clients: https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/awscore/client/builder/AwsClientBuilder.html
   
   There is a similar config in S3Configuration: https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/S3Configuration.html
   
   Could you take a look at if enabling one and not another would fail or cause the feature to be not enabled?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org