[GitHub] [incubator-pekko-persistence-jdbc] nafg commented on a diff in pull request #44: Add Scala 3 support

["nafg (via GitHub)" <gi...@apache.org>]

nafg commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1257991852


##########
project/Dependencies.scala:
##########
@@ -8,16 +8,18 @@
  */
 
 import sbt._
+import Keys._
 
 object Dependencies {
   // Keep in sync with .github CI build
   val Scala212 = "2.12.18"
   val Scala213 = "2.13.11"
-  val ScalaVersions = Seq(Scala212, Scala213)
+  val Scala3 = "3.3.0"
+  val ScalaVersions = Seq(Scala212, Scala213, Scala3)
 
   val PekkoVersion = "1.0.0-RC3"
 
-  val SlickVersion = "3.3.3"
+  val SlickVersion = "3.5.0-M4"

Review Comment:
   > one solution would be to use Slack 3.3.3 for Scala 2 and 3.5.0-M4 for Scala 3 - that way Scala 2 users won't have t use a pre-release milestone
   
   There's 3.4.1. But I don't recommend having different versions. How soon do you need to release?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org