[GitHub] [skywalking] BFergerson edited a comment on issue #7040: Does GRPCLogReportServiceClient support TLS?

[GitBox <gi...@apache.org>]

BFergerson edited a comment on issue #7040:
URL: https://github.com/apache/skywalking/issues/7040#issuecomment-852147819


   I'm not sure how I should be implementing this but I was just testing adding `TLSChannelBuilder` and I get an error like above.
   
   For example, changing this:
   ```java
   channel = ManagedChannelBuilder
               .forAddress(
                   ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.SERVER_HOST,
                   ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.SERVER_PORT
               )
               .usePlaintext()
               .build();
   ```
   
   To this:
   ```java
   channel = new TLSChannelBuilder().build(NettyChannelBuilder
               .forAddress(
                   ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.SERVER_HOST,
                   ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.SERVER_PORT
               ))
               .build();
   ```
   
   Causes this:
   ```
   incompatible types: io.grpc.netty.NettyChannelBuilder cannot be converted to org.apache.skywalking.apm.dependencies.io.grpc.netty.NettyChannelBuilder
   ```
   
   I've tried playing around with the shade settings for `apm-toolkit-logging-common` but nothing seems to fix it.
   I'd appreciate a little direction. I get the same issues trying to reuse `GRPCChannelManager`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org