You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Jon Moore (Commented) (JIRA)" <ji...@apache.org> on 2012/01/12 21:02:39 UTC
[jira] [Commented] (HTTPCLIENT-1153)
org.apache.http.impl.client.cache.memcached.MemcachedHttpCacheStorage uses
URL as cache key - shouldn't.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185192#comment-13185192 ]
Jon Moore commented on HTTPCLIENT-1153:
---------------------------------------
Hey all, I'm starting to work on this. I realized once we start hashing the keys there is a possibility (however remote) that we'll get collisions, so I am working on a not-overly-complicated solution to serialize the original URL key in with the cache entry itself, so it can be compared when we retrieve it. I'll be sure to go back around and add all the proper factory/interface/dependency-injection framework to make sure it's extensible.
> org.apache.http.impl.client.cache.memcached.MemcachedHttpCacheStorage uses URL as cache key - shouldn't.
> --------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1153
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1153
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.1.1, 4.1.2
> Reporter: Clinton Nielsen
> Assignee: Jon Moore
> Fix For: 4.1.3, 4.2 Alpha2
>
>
> Spy memcached has 250 defined as max key length:
> http://dustin.github.com/java-memcached-client/apidocs/constant-values.html#net.spy.memcached.MemcachedClientIF.MAX_KEY_LENGTH
> URLs can be (and often are) much longer than 250 characters.
> URLs should be hashed before being used as keys.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org