You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/01 22:23:56 UTC

[GitHub] [cloudstack-documentation] Hudratronium opened a new pull request #194: clearification of the advanced network setup in section "Host KVM installation"

Hudratronium opened a new pull request #194:
URL: https://github.com/apache/cloudstack-documentation/pull/194


   I rewrote the setup-description, thinking is gives a better overview of the logical topology of the setup.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-documentation] Hudratronium commented on a change in pull request #194: clearification of the advanced network setup in section "Host KVM installation"

Posted by GitBox <gi...@apache.org>.
Hudratronium commented on a change in pull request #194:
URL: https://github.com/apache/cloudstack-documentation/pull/194#discussion_r588691197



##########
File path: source/installguide/hypervisor/kvm.rst
##########
@@ -645,11 +645,10 @@ although a reboot is recommended to see if everything works properly.
 Network Example for Advanced Networks
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-In the Advanced networking mode is most common to have (at least) two physical interfaces.
-In this example we will again have the hypervisor management interface on cloudbr0 on the 
-untagged (native) VLAN. But now we will have a bridge on top of our additional interface (eth1)
-for public and guest traffic with no VLANs applied by us - CloudStack will add the VLANs
-as required.
+In the Advanced networking mode is most common to have (at least) two physical interfaces per hypervior-host.
+We will use the interface eth0 linked to the bridge 'cloudbr0' using the untagged (native) VLAN for hypervisor management.
+Additionally we configure a the second interface for usage with the bridge 'cloudbr1' for public and guest traffic.

Review comment:
       Added suggestions  - thanks for checking and reading carefully :-) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-documentation] rhtyd merged pull request #194: clearification of the advanced network setup in section "Host KVM installation"

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #194:
URL: https://github.com/apache/cloudstack-documentation/pull/194


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #194: clearification of the advanced network setup in section "Host KVM installation"

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #194:
URL: https://github.com/apache/cloudstack-documentation/pull/194#issuecomment-791503594


   requesting docbuild


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-documentation] GabrielBrascher commented on a change in pull request #194: clearification of the advanced network setup in section "Host KVM installation"

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #194:
URL: https://github.com/apache/cloudstack-documentation/pull/194#discussion_r588507443



##########
File path: source/installguide/hypervisor/kvm.rst
##########
@@ -645,11 +645,10 @@ although a reboot is recommended to see if everything works properly.
 Network Example for Advanced Networks
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-In the Advanced networking mode is most common to have (at least) two physical interfaces.
-In this example we will again have the hypervisor management interface on cloudbr0 on the 
-untagged (native) VLAN. But now we will have a bridge on top of our additional interface (eth1)
-for public and guest traffic with no VLANs applied by us - CloudStack will add the VLANs
-as required.
+In the Advanced networking mode is most common to have (at least) two physical interfaces per hypervior-host.
+We will use the interface eth0 linked to the bridge 'cloudbr0' using the untagged (native) VLAN for hypervisor management.
+Additionally we configure a the second interface for usage with the bridge 'cloudbr1' for public and guest traffic.

Review comment:
       `Additionally we configure a the second interface`
   :arrow_down: I would suggest removing `a`, but you might remove `the` instead, if you prefer
   `Additionally, we configure the second interface`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-documentation] DaanHoogland commented on a change in pull request #194: clearification of the advanced network setup in section "Host KVM installation"

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #194:
URL: https://github.com/apache/cloudstack-documentation/pull/194#discussion_r585338334



##########
File path: source/installguide/hypervisor/kvm.rst
##########
@@ -694,7 +693,7 @@ Make sure it looks similar to:
    TYPE=Ethernet
    BRIDGE=cloudbr0
 
-We now have to configure the VLAN interfaces:
+We now have to configure the second network-interface:

Review comment:
       ```suggestion
   We now have to configure the second network-interface for use in guest VLANs:
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #194: clearification of the advanced network setup in section "Host KVM installation"

Posted by GitBox <gi...@apache.org>.
ACSGitBot commented on pull request #194:
URL: https://github.com/apache/cloudstack-documentation/pull/194#issuecomment-791505373


   Build finished.  You can review it at:   https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr194//
   
   Build Log Output:
   
   
   No log errors found to report.//


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #194: clearification of the advanced network setup in section "Host KVM installation"

Posted by GitBox <gi...@apache.org>.
ACSGitBot commented on pull request #194:
URL: https://github.com/apache/cloudstack-documentation/pull/194#issuecomment-791503632


   Your request had been received, i'll go and build the documentation and check the output log for errors.
   
   This shouldn't take long.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org