You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/07/02 20:12:16 UTC
Review Request 12236: Fixed broken JVM tests on OS X by endabling headless
mode for AWT.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12236/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-524
https://issues.apache.org/jira/browse/MESOS-524
Repository: mesos
Description
-------
See MESOS-524.
Diffs
-----
src/jvm/jvm.cpp d053f59416ccd85517fc4749bf3e5a3d88295c7e
Diff: https://reviews.apache.org/r/12236/diff/
Testing
-------
make check on OS X and Linux
Thanks,
Ben Mahler
Re: Review Request 12236: Fixed broken JVM tests on OS X by endabling
headless mode for AWT.
Posted by Ben Mahler <be...@gmail.com>.
> On July 2, 2013, 7:16 p.m., Vinod Kone wrote:
> > I'm assuming you were able to repro the behavior w/o the fix on OSX and this fixed it? Did you have to run in multiple times to repro/confirm?
Yep, the build was consistently broken on my Mac, so it always failed and now it works.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12236/#review22683
-----------------------------------------------------------
On July 2, 2013, 6:12 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12236/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 6:12 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-524
> https://issues.apache.org/jira/browse/MESOS-524
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-524.
>
>
> Diffs
> -----
>
> src/jvm/jvm.cpp d053f59416ccd85517fc4749bf3e5a3d88295c7e
>
> Diff: https://reviews.apache.org/r/12236/diff/
>
>
> Testing
> -------
>
> make check on OS X and Linux
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 12236: Fixed broken JVM tests on OS X by endabling
headless mode for AWT.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12236/#review22683
-----------------------------------------------------------
Ship it!
I'm assuming you were able to repro the behavior w/o the fix on OSX and this fixed it? Did you have to run in multiple times to repro/confirm?
- Vinod Kone
On July 2, 2013, 6:12 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12236/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 6:12 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-524
> https://issues.apache.org/jira/browse/MESOS-524
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-524.
>
>
> Diffs
> -----
>
> src/jvm/jvm.cpp d053f59416ccd85517fc4749bf3e5a3d88295c7e
>
> Diff: https://reviews.apache.org/r/12236/diff/
>
>
> Testing
> -------
>
> make check on OS X and Linux
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 12236: Fixed broken JVM tests on OS X by endabling
headless mode for AWT.
Posted by Brian KimJohnson <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12236/#review22699
-----------------------------------------------------------
Ship it!
Confirmed this patch fixes for me as well. Thanks!
- Brian KimJohnson
On July 2, 2013, 6:12 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12236/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 6:12 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-524
> https://issues.apache.org/jira/browse/MESOS-524
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-524.
>
>
> Diffs
> -----
>
> src/jvm/jvm.cpp d053f59416ccd85517fc4749bf3e5a3d88295c7e
>
> Diff: https://reviews.apache.org/r/12236/diff/
>
>
> Testing
> -------
>
> make check on OS X and Linux
>
>
> Thanks,
>
> Ben Mahler
>
>