You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ti...@apache.org on 2020/07/01 16:45:38 UTC

[cordova-plugin-dialogs] branch fix/remove-old-platform-code created (now ec7b9eb)

This is an automated email from the ASF dual-hosted git repository.

timbru31 pushed a change to branch fix/remove-old-platform-code
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-dialogs.git.


      at ec7b9eb  fix: remove deprecated platform snippet

This branch includes the following new commits:

     new ec7b9eb  fix: remove deprecated platform snippet

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[cordova-plugin-dialogs] 01/01: fix: remove deprecated platform snippet

Posted by ti...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

timbru31 pushed a commit to branch fix/remove-old-platform-code
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-dialogs.git

commit ec7b9ebd714ed10af06b1beed82c91d8cd7a0afe
Author: Tim Brust <ti...@sinnerschrader.com>
AuthorDate: Wed Jul 1 18:45:23 2020 +0200

    fix: remove deprecated platform snippet
---
 www/notification.js | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/www/notification.js b/www/notification.js
index 7ae7e31..1de7b52 100644
--- a/www/notification.js
+++ b/www/notification.js
@@ -114,16 +114,7 @@ function convertButtonLabels (buttonLabels) {
     // Some platforms take an array of button label names.
     // Other platforms take a comma separated list.
     // For compatibility, we convert to the desired type based on the platform.
-    if (
-        platform.id === 'amazon-fireos' ||
-        platform.id === 'android' ||
-        platform.id === 'ios' ||
-        platform.id === 'windowsphone' ||
-        platform.id === 'firefoxos' ||
-        platform.id === 'ubuntu' ||
-        platform.id === 'windows8' ||
-        platform.id === 'windows'
-    ) {
+    if (platform.id === 'android' || platform.id === 'ios' || platform.id === 'windows') {
         if (typeof buttonLabels === 'string') {
             buttonLabels = buttonLabels.split(','); // not crazy about changing the var type here
         }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org