You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "caicancai (via GitHub)" <gi...@apache.org> on 2024/06/12 15:02:37 UTC
[PR] [Improvement] Add deregistryTest on Master moudle [dolphinscheduler]
caicancai opened a new pull request, #16142:
URL: https://github.com/apache/dolphinscheduler/pull/16142
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] Add deregister Test on Master moudle [dolphinscheduler]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #16142:
URL: https://github.com/apache/dolphinscheduler/pull/16142#issuecomment-2163332420
## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/16142?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 40.71%. Comparing base [(`a13eacd`)](https://app.codecov.io/gh/apache/dolphinscheduler/commit/a13eacd61c7a098bb820b1e656889bc5ed9e5a5e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`f7e9849`)](https://app.codecov.io/gh/apache/dolphinscheduler/commit/f7e9849ab745fef6d64bf4e0e651f3cf0bb98b56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: **Current head f7e9849 differs from pull request most recent head ac3875b**
>
> Please [upload](https://docs.codecov.com/docs/codecov-uploader) reports for the commit ac3875b to get more accurate results.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev #16142 +/- ##
============================================
- Coverage 40.73% 40.71% -0.02%
+ Complexity 5250 5246 -4
============================================
Files 1385 1385
Lines 46109 46076 -33
Branches 4923 4899 -24
============================================
- Hits 18781 18759 -22
+ Misses 25401 25389 -12
- Partials 1927 1928 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dolphinscheduler/pull/16142?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] Add deregister Test on Master moudle [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16142:
URL: https://github.com/apache/dolphinscheduler/pull/16142#issuecomment-2163348638
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16142) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16142&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16142&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16142&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16142&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16142)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] Add deregister Test on Master moudle [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16142:
URL: https://github.com/apache/dolphinscheduler/pull/16142#issuecomment-2163347690
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16142) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16142&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16142&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16142&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16142&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16142)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] Add deregister Test on Master moudle [dolphinscheduler]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #16142:
URL: https://github.com/apache/dolphinscheduler/pull/16142#issuecomment-2164232914
> https://github.com/apache/dolphinscheduler/blob/a13eacd61c7a098bb820b1e656889bc5ed9e5a5e/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistryClient.java#L188-L200
>
> IMHO at least you need to verify the behavior of injected registryClient mock after calling `masterRegistryClient.deregister()`. To make things fully covered, you may also test the exception handling block, which is no necessary in this case though. Simply calling `masterRegistryClient.deregister()` is not a meaningful test case.
Thanks, I will close this pr and see if there is any way to improve it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] Add deregister Test on Master moudle [dolphinscheduler]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai closed pull request #16142: [Improvement] Add deregister Test on Master moudle
URL: https://github.com/apache/dolphinscheduler/pull/16142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org