You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "nabarun (JIRA)" <ji...@apache.org> on 2018/10/03 21:38:24 UTC

[jira] [Closed] (GEODE-5630) Some tests using await should use until instead of untilAsserted

     [ https://issues.apache.org/jira/browse/GEODE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nabarun closed GEODE-5630.
--------------------------

> Some tests using await should use until instead of untilAsserted
> ----------------------------------------------------------------
>
>                 Key: GEODE-5630
>                 URL: https://issues.apache.org/jira/browse/GEODE-5630
>             Project: Geode
>          Issue Type: Bug
>          Components: tests
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Awaitility was upgraded for GEODE-5593 and most or all of the await()...until() calls were changed to await()...untilAsserted(). One or more of these that are now incorrect.
> BucketCreationCrashCompletesRegressionTest line 173 is now:
> {noformat}
>       await().atMost(2, MINUTES).untilAsserted(() -> {
>         hasBucketOwners(partitionedRegion, bucketId);
>       });
> {noformat}
> But hasBucketOwners returns a boolean and does not perform any assertions.
> I'll fix this test and then review every other test that was changed to use untilAsserted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)