You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/07/21 14:32:54 UTC
Review Request 61034: Minor style cleanups in process.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61034/
-----------------------------------------------------------
Review request for mesos, Armand Grillet and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c
Diff: https://reviews.apache.org/r/61034/diff/1/
Testing
-------
make check on Mac OS X and several Linux distros.
Thanks,
Alexander Rukletsov
Re: Review Request 61034: Minor style cleanups in process.cpp.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61034/#review181397
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61034/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 2:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c
>
>
> Diff: https://reviews.apache.org/r/61034/diff/1/
>
>
> Testing
> -------
>
> make check on Mac OS X and several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61034: Minor style cleanups in process.cpp.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61034/#review181412
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61028, 61029, 61030, 61031, 61032, 61033, 61034]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61034/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 2:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c
>
>
> Diff: https://reviews.apache.org/r/61034/diff/1/
>
>
> Testing
> -------
>
> make check on Mac OS X and several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61034: Minor style cleanups in process.cpp.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61034/
-----------------------------------------------------------
(Updated July 28, 2017, 2:33 p.m.)
Review request for mesos, Armand Grillet and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c
Diff: https://reviews.apache.org/r/61034/diff/2/
Testing
-------
make check on Mac OS X and several Linux distros.
Thanks,
Alexander Rukletsov
Re: Review Request 61034: Minor style cleanups in process.cpp.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61034/
-----------------------------------------------------------
(Updated July 28, 2017, 2:32 p.m.)
Review request for mesos, Armand Grillet and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c
Diff: https://reviews.apache.org/r/61034/diff/2/
Changes: https://reviews.apache.org/r/61034/diff/1-2/
Testing
-------
make check on Mac OS X and several Linux distros.
Thanks,
Alexander Rukletsov
Re: Review Request 61034: Minor style cleanups in process.cpp.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61034/#review181176
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61034/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 2:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c
>
>
> Diff: https://reviews.apache.org/r/61034/diff/1/
>
>
> Testing
> -------
>
> make check on Mac OS X and several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>