Re: [PR] Helm: Fix PgBouncer hostname for result backend under standard naming [airflow]

["Miretpl (via GitHub)" <gi...@apache.org>]

Miretpl commented on code in PR #71830:
URL: https://github.com/apache/airflow/pull/71830#discussion_r3914960152


##########
chart/tests/helm_tests/security/test_result_backend_connection_secret.py:
##########
@@ -127,7 +127,23 @@ def test_should_set_pgbouncer_overrides_with_non_chart_database_when_enabled(sel
 
         # host, port, dbname still get overridden even with an non-chart db
         assert (
-            connection == "db+postgresql://someuser:somepass@release-name-pgbouncer:6543"
+            connection == "db+postgresql://someuser:somepass@release-name-pgbouncer.default:6543"
+            "/release-name-result-backend?sslmode=allow"
+        )
+
+    def test_should_set_pgbouncer_overrides_with_use_standard_naming(self):
+        # The pgbouncer host must be derived from the "airflow.fullname" template (like the metadata

Review Comment:
   This is how useStandardNaming/fullnameOverride works, so we can delete this comment here. Test name is descriptive enough.



##########
chart/newsfragments/PR_NUMBER_PLACEHOLDER.bugfix.rst:
##########
@@ -0,0 +1 @@
+Fix PgBouncer connection routing in the auto-generated result backend secret to use the ``airflow.fullname`` naming convention, matching the metadata connection secret. Previously it pointed at a non-existent PgBouncer host whenever ``useStandardNaming`` or ``fullnameOverride`` changed the release naming.

Review Comment:
   I think we can delete this newsfragment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org