You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/06/25 13:25:23 UTC

[GitHub] [couchdb] bessbd opened a new pull request #3639: Format all erl files

bessbd opened a new pull request #3639:
URL: https://github.com/apache/couchdb/pull/3639


   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   This is a follow-up PR to https://github.com/apache/couchdb/pull/3568 . The motivation is https://github.com/apache/couchdb/pull/3568#issuecomment-853943222 . Since erlfmt ensures semantics don't change on formatting _and_ we've verified the `beam`s are okay, it's safe to assume we can run the formatter on all files internal to this repo.
   
   ## Testing recommendations
   All but 2 files formatted are test files. Tests should run the same as previously. There are 2 additional files changed; I've checked them manually.
   
   ## Related Issues or Pull Requests
   https://github.com/apache/couchdb/pull/3568
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] bessbd merged pull request #3639: Format all erl files

Posted by GitBox <gi...@apache.org>.
bessbd merged pull request #3639:
URL: https://github.com/apache/couchdb/pull/3639


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] bessbd commented on pull request #3639: Format all erl files

Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3639:
URL: https://github.com/apache/couchdb/pull/3639#issuecomment-869622707


   Thank you for the review, @iilyak ! I'm about to merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org