[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3682: Add sort by privilege level to TO and use it in TP

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #3682: Add sort by privilege level to TO and use it in TP
URL: https://github.com/apache/trafficcontrol/pull/3682#discussion_r310728452
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go
 ##########
 @@ -59,10 +59,21 @@ func BuildWhereAndOrderBy(parameters map[string]string, queryParamsToSQLCols map
 		if colInfo, ok := queryParamsToSQLCols[orderby]; ok {
 			log.Debugln("orderby column ", colInfo)
 			orderBy += " " + colInfo.Column
+
+			// if orderby is specified and valid, also check for sortOrder
+			if sortOrder, exists := parameters["sortOrder"]; exists {
+				log.Debugln("sortOrder: ", sortOrder)
 
 Review comment:
   Is this going to be compatible with #3701 ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services