[GitHub] [incubator-superset] khtruong commented on a change in pull request #7086: WIP: Enable color consistency in a dashboard (Need to add unit tests)

[GitBox <gi...@apache.org>]

khtruong commented on a change in pull request #7086: WIP: Enable color consistency in a dashboard (Need to add unit tests)
URL: https://github.com/apache/incubator-superset/pull/7086#discussion_r268003789
 
 

 ##########
 File path: superset/assets/src/dashboard/reducers/getInitialState.js
 ##########
 @@ -149,6 +157,17 @@ export default function(bootstrapData) {
     },
   };
 
+  // store the color scheme as a layout component so we can undo/redo changes
+  layout[COLOR_SCHEME_ID] = {
 
 Review comment:
   Sure! But if I move it out of layout, changing color schemes will not be an undoable/redoable action based on how the things are set up at the moment. If people don't care about it being undoable/redoable, I can definitely move it out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org