You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2025/09/19 22:57:39 UTC
[kudu-CR] Fix build failure in ARM machines
Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23446
Change subject: Fix build failure in ARM machines
......................................................................
Fix build failure in ARM machines
This fixes build failure in ARM machines which is caused due
to db4f8e2.
Build is successful after this fix.
Change-Id: Ib4bc3c5f7317531f8c5a98e397916a8d13c1ddc1
---
M src/kudu/common/columnar_serialization.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/23446/1
--
To view, visit http://gerrit.cloudera.org:8080/23446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4bc3c5f7317531f8c5a98e397916a8d13c1ddc1
Gerrit-Change-Number: 23446
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
[kudu-CR] Fix build failure in ARM machines
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23446 )
Change subject: Fix build failure in ARM machines
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1824/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc3c5f7317531f8c5a98e397916a8d13c1ddc1
Gerrit-Change-Number: 23446
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 20 Sep 2025 00:11:00 +0000
Gerrit-HasComments: No
[kudu-CR] Fix build failure in ARM machines
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23446 )
Change subject: Fix build failure in ARM machines
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23446/1/src/kudu/common/columnar_serialization.cc
File src/kudu/common/columnar_serialization.cc:
http://gerrit.cloudera.org:8080/#/c/23446/1/src/kudu/common/columnar_serialization.cc@347
PS1, Line 347: defined(__x86_64__)
Yes, that's the right way to use this, and this is consistent with other places in the code. Thank you for the fix!
--
To view, visit http://gerrit.cloudera.org:8080/23446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc3c5f7317531f8c5a98e397916a8d13c1ddc1
Gerrit-Change-Number: 23446
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 19 Sep 2025 23:03:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] Fix build failure in ARM machines
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23446 )
Change subject: Fix build failure in ARM machines
......................................................................
Fix build failure in ARM machines
This fixes build failure in ARM machines which is caused due
to db4f8e2.
Build is successful after this fix.
Change-Id: Ib4bc3c5f7317531f8c5a98e397916a8d13c1ddc1
Reviewed-on: http://gerrit.cloudera.org:8080/23446
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/common/columnar_serialization.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Abhishek Chennaka: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4bc3c5f7317531f8c5a98e397916a8d13c1ddc1
Gerrit-Change-Number: 23446
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Fix build failure in ARM machines
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23446 )
Change subject: Fix build failure in ARM machines
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1824/
--
To view, visit http://gerrit.cloudera.org:8080/23446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc3c5f7317531f8c5a98e397916a8d13c1ddc1
Gerrit-Change-Number: 23446
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 19 Sep 2025 22:57:46 +0000
Gerrit-HasComments: No
[kudu-CR] Fix build failure in ARM machines
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23446 )
Change subject: Fix build failure in ARM machines
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc3c5f7317531f8c5a98e397916a8d13c1ddc1
Gerrit-Change-Number: 23446
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 20 Sep 2025 04:24:48 +0000
Gerrit-HasComments: No
[kudu-CR] Fix build failure in ARM machines
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has removed a vote on this change.
Change subject: Fix build failure in ARM machines
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib4bc3c5f7317531f8c5a98e397916a8d13c1ddc1
Gerrit-Change-Number: 23446
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)