You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by charsyam <gi...@git.apache.org> on 2014/11/13 15:20:46 UTC

[GitHub] tajo pull request: add large size for servername

GitHub user charsyam opened a pull request:

    https://github.com/apache/tajo/pull/240

    add large size for servername

    In tajo-core/src/main/java/org/apache/tajo/master/cluster/ServerName.java.
    In getServerName, Creating StringBuilder With (hostName.length() + 4)
    
    but like below, it is short, so it call internally newCapacity() if port size is larger than 3 
    ```java
         name.append(hostName); //+hostName.length()
         name.append(SERVERNAME_SEPARATOR); //+1
         name.append(port); //port range is 0 <= port range <= 65535
    ```
    
    so this patch. prevent newCapacity() internally doing allocating proper size.
    
    but. It just change value from 4 to 8(to cover port range 65535)
    It passed testcases.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/charsyam/tajo feature/add_more_number_for_servername

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/240.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #240
    
----
commit 515980f0f69f46f526f8fcb195c94ce8af84013a
Author: clark.kang <cl...@kakao.com>
Date:   2014-11-13T14:13:14Z

    add large size for servername

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1173: Add size 8 instead of 4 For ServerNa...

Posted by charsyam <gi...@git.apache.org>.
Github user charsyam closed the pull request at:

    https://github.com/apache/tajo/pull/240


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---