[GitHub] [arrow] wgtmac commented on pull request #34054: GH-34053: [C++][Parquet] Write parquet page index

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on PR #34054:
URL: https://github.com/apache/arrow/pull/34054#issuecomment-1449327396

   > > > Apologies if I missed it but do you plan to add truncation functionality for large stat values?
   > > 
   > > 
   > > Large stats truncation is already implemented by parquet-cpp: https://github.com/apache/arrow/blob/main/cpp/src/parquet/statistics.h#L145. So we are good here.
   > 
   > Does the referenced code only apply to statistics in the chunk metadata (and page headers)? Statistics in the page indexes can and should be truncated since there are no guarantees that those statistics are actually contained in the page. See [second bullet](https://github.com/apache/parquet-format/blob/master/PageIndex.md#technical-approach) under "Some observations:".
   
   It applies to both page stats (in the header) and column chunk stats. In this PR, page index directly collects page stats after truncation. So it should not be a problem here. @etseidl 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org