You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kp...@apache.org on 2013/10/13 00:04:40 UTC
svn commit: r1531601 - in /tomcat/tc7.0.x/trunk: ./
webapps/examples/WEB-INF/classes/websocket/drawboard/DrawboardEndpoint.java
webapps/examples/WEB-INF/classes/websocket/drawboard/Room.java
Author: kpreisser
Date: Sat Oct 12 22:04:39 2013
New Revision: 1531601
URL: http://svn.apache.org/r1531601
Log:
Update some comments.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawboardEndpoint.java
tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/Room.java
Propchange: tomcat/tc7.0.x/trunk/
------------------------------------------------------------------------------
Merged /tomcat/trunk:r1531600
Modified: tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawboardEndpoint.java
URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawboardEndpoint.java?rev=1531601&r1=1531600&r2=1531601&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawboardEndpoint.java (original)
+++ tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawboardEndpoint.java Sat Oct 12 22:04:39 2013
@@ -158,7 +158,7 @@ public final class DrawboardEndpoint ext
// (starting with char '1'), and pong messages (starting
// with char '0').
// Draw messages should look like this:
- // ID|type,colR,colB,colG,colA,thickness,x1,y1,x2,y2
+ // ID|type,colR,colB,colG,colA,thickness,x1,y1,x2,y2,lastInChain
boolean dontSwallowException = false;
try {
Modified: tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/Room.java
URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/Room.java?rev=1531601&r1=1531600&r2=1531601&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/Room.java (original)
+++ tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/Room.java Sat Oct 12 22:04:39 2013
@@ -231,7 +231,7 @@ public final class Room {
/**
- * Broadcasts the given drawboard message to all connected players.
+ * Broadcasts the given drawboard message to all connected players.<br>
* Note: For DrawMessages, please use
* {@link #broadcastDrawMessage(DrawMessage)}
* as this method will buffer them and prefix them with the correct
@@ -276,7 +276,7 @@ public final class Room {
private void broadcastTimerTick() {
// For each Player, send all per Player buffered
// DrawMessages, prefixing each DrawMessage with the player's
- // lastReceuvedMessageId.
+ // lastReceivedMessageId.
// Multiple messages are concatenated with "|".
for (Player p : players) {
@@ -331,6 +331,7 @@ public final class Room {
public void shutdown() {
roomExecutor.shutdown();
drawmessageBroadcastTimer.cancel();
+ // TODO: Dispose of BufferedImage and Graphics2D
}
@@ -339,7 +340,7 @@ public final class Room {
* {@link Room} and the {@link Client}.<br><br>
*
* Note: This means a player object is actually a join between Room and
- * Endpoint.
+ * Client.
*/
public final class Player {
@@ -358,8 +359,6 @@ public final class Room {
/**
* Buffered DrawMessages that will be sent by a Timer.
- * TODO: This should be refactored to be in a Room-Player join class
- * as this is room-specific.
*/
private final List<DrawMessage> bufferedDrawMessages =
new ArrayList<DrawMessage>();
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org