You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/12/20 16:27:48 UTC
Re: Review Request 64070: WIP: Ensured executor adapter propagates
error and shutdown messages.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64070/
-----------------------------------------------------------
(Updated Dec. 20, 2017, 4:27 p.m.)
Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.
Summary (updated)
-----------------
WIP: Ensured executor adapter propagates error and shutdown messages.
Repository: mesos
Description
-------
Prior to this patch, if an error or shutdown occurred during
subscription / registration with the agent, it was not propagated back
to the executor if the v0_v1 executor adapter was used. This happened
because the adapter did not call the `connected` callback until after
successful registration and hence the executor did not even try to
send the `SUBSCRIBE` call, without which the adapter did not send any
events to the executor.
A fix is to call the `connected` callback if an error occurred or
shutdown even arrived before the executor had subscribed.
Diffs
-----
src/executor/v0_v1executor.cpp 61d591993e6388ba3b4d64a3bdb63c3a3513fbeb
Diff: https://reviews.apache.org/r/64070/diff/1/
Testing
-------
Thanks,
Alexander Rukletsov
Re: Review Request 64070: Ensured executor adapter propagates error
and shutdown messages.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64070/
-----------------------------------------------------------
(Updated Dec. 22, 2017, 11:08 a.m.)
Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.
Bugs: MESOS-8297
https://issues.apache.org/jira/browse/MESOS-8297
Repository: mesos
Description
-------
Prior to this patch, if an error, kill, or shutdown occurred during
subscription / registration with the agent, it was not propagated back
to the executor if the v0_v1 executor adapter was used. This happened
because the adapter did not call the `connected` callback until after
successful registration and hence the executor did not even try to
send the `SUBSCRIBE` call, without which the adapter did not send any
events to the executor.
A fix is to call the `connected` callback if an error occurred or
shutdown / kill event arrived before the executor had subscribed.
Diffs
-----
src/executor/v0_v1executor.cpp 61d591993e6388ba3b4d64a3bdb63c3a3513fbeb
Diff: https://reviews.apache.org/r/64070/diff/4/
Testing
-------
Thanks,
Alexander Rukletsov
Re: Review Request 64070: Ensured executor adapter propagates error
and shutdown messages.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64070/
-----------------------------------------------------------
(Updated Dec. 21, 2017, 4:07 p.m.)
Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.
Changes
-------
Removed debug traces.
Repository: mesos
Description
-------
Prior to this patch, if an error, kill, or shutdown occurred during
subscription / registration with the agent, it was not propagated back
to the executor if the v0_v1 executor adapter was used. This happened
because the adapter did not call the `connected` callback until after
successful registration and hence the executor did not even try to
send the `SUBSCRIBE` call, without which the adapter did not send any
events to the executor.
A fix is to call the `connected` callback if an error occurred or
shutdown / kill event arrived before the executor had subscribed.
Diffs (updated)
-----
src/executor/v0_v1executor.cpp 61d591993e6388ba3b4d64a3bdb63c3a3513fbeb
Diff: https://reviews.apache.org/r/64070/diff/4/
Changes: https://reviews.apache.org/r/64070/diff/3-4/
Testing
-------
Thanks,
Alexander Rukletsov
Re: Review Request 64070: Ensured executor adapter propagates error
and shutdown messages.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64070/
-----------------------------------------------------------
(Updated Dec. 21, 2017, 3:40 p.m.)
Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.
Repository: mesos
Description
-------
Prior to this patch, if an error, kill, or shutdown occurred during
subscription / registration with the agent, it was not propagated back
to the executor if the v0_v1 executor adapter was used. This happened
because the adapter did not call the `connected` callback until after
successful registration and hence the executor did not even try to
send the `SUBSCRIBE` call, without which the adapter did not send any
events to the executor.
A fix is to call the `connected` callback if an error occurred or
shutdown / kill event arrived before the executor had subscribed.
Diffs (updated)
-----
src/executor/v0_v1executor.cpp 61d591993e6388ba3b4d64a3bdb63c3a3513fbeb
Diff: https://reviews.apache.org/r/64070/diff/3/
Changes: https://reviews.apache.org/r/64070/diff/2-3/
Testing
-------
Thanks,
Alexander Rukletsov
Re: Review Request 64070: Ensured executor adapter propagates error
and shutdown messages.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64070/#review194339
-----------------------------------------------------------
src/executor/v0_v1executor.cpp
Lines 192 (patched)
<https://reviews.apache.org/r/64070/#comment273101>
Can you please move this check to the beginning of the method for better code consistency here and in `shutdown`, `killTask` methods?
- Andrei Budnik
On Dec. 20, 2017, 8:16 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64070/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2017, 8:16 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prior to this patch, if an error, kill, or shutdown occurred during
> subscription / registration with the agent, it was not propagated back
> to the executor if the v0_v1 executor adapter was used. This happened
> because the adapter did not call the `connected` callback until after
> successful registration and hence the executor did not even try to
> send the `SUBSCRIBE` call, without which the adapter did not send any
> events to the executor.
>
> A fix is to call the `connected` callback if an error occurred or
> shutdown / kill event arrived before the executor had subscribed.
>
>
> Diffs
> -----
>
> src/executor/v0_v1executor.cpp 61d591993e6388ba3b4d64a3bdb63c3a3513fbeb
>
>
> Diff: https://reviews.apache.org/r/64070/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 64070: Ensured executor adapter propagates error
and shutdown messages.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64070/#review194340
-----------------------------------------------------------
Ship it!
Ship It!
- Andrei Budnik
On Dec. 20, 2017, 8:16 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64070/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2017, 8:16 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prior to this patch, if an error, kill, or shutdown occurred during
> subscription / registration with the agent, it was not propagated back
> to the executor if the v0_v1 executor adapter was used. This happened
> because the adapter did not call the `connected` callback until after
> successful registration and hence the executor did not even try to
> send the `SUBSCRIBE` call, without which the adapter did not send any
> events to the executor.
>
> A fix is to call the `connected` callback if an error occurred or
> shutdown / kill event arrived before the executor had subscribed.
>
>
> Diffs
> -----
>
> src/executor/v0_v1executor.cpp 61d591993e6388ba3b4d64a3bdb63c3a3513fbeb
>
>
> Diff: https://reviews.apache.org/r/64070/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 64070: Ensured executor adapter propagates error
and shutdown messages.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64070/
-----------------------------------------------------------
(Updated Dec. 20, 2017, 8:16 p.m.)
Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.
Summary (updated)
-----------------
Ensured executor adapter propagates error and shutdown messages.
Repository: mesos
Description (updated)
-------
Prior to this patch, if an error, kill, or shutdown occurred during
subscription / registration with the agent, it was not propagated back
to the executor if the v0_v1 executor adapter was used. This happened
because the adapter did not call the `connected` callback until after
successful registration and hence the executor did not even try to
send the `SUBSCRIBE` call, without which the adapter did not send any
events to the executor.
A fix is to call the `connected` callback if an error occurred or
shutdown / kill event arrived before the executor had subscribed.
Diffs (updated)
-----
src/executor/v0_v1executor.cpp 61d591993e6388ba3b4d64a3bdb63c3a3513fbeb
Diff: https://reviews.apache.org/r/64070/diff/2/
Changes: https://reviews.apache.org/r/64070/diff/1-2/
Testing
-------
Thanks,
Alexander Rukletsov
Re: Review Request 64070: WIP: Ensured executor adapter propagates
error and shutdown messages.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64070/#review194262
-----------------------------------------------------------
PASS: Mesos patch 64070 was successfully built and tested.
Reviews applied: `['64070']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64070
- Mesos Reviewbot Windows
On Dec. 20, 2017, 4:27 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64070/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2017, 4:27 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prior to this patch, if an error or shutdown occurred during
> subscription / registration with the agent, it was not propagated back
> to the executor if the v0_v1 executor adapter was used. This happened
> because the adapter did not call the `connected` callback until after
> successful registration and hence the executor did not even try to
> send the `SUBSCRIBE` call, without which the adapter did not send any
> events to the executor.
>
> A fix is to call the `connected` callback if an error occurred or
> shutdown even arrived before the executor had subscribed.
>
>
> Diffs
> -----
>
> src/executor/v0_v1executor.cpp 61d591993e6388ba3b4d64a3bdb63c3a3513fbeb
>
>
> Diff: https://reviews.apache.org/r/64070/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rukletsov
>
>