You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/06/05 17:00:00 UTC

[GitHub] [helix] alirezazamani commented on a change in pull request #1064: Avoid adding JobConfig if queue has reached its capacity limit

alirezazamani commented on a change in pull request #1064:
URL: https://github.com/apache/helix/pull/1064#discussion_r436047353



##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java
##########
@@ -403,6 +403,14 @@ public void enqueueJobs(final String queue, final List<String> jobs,
       }
     }
 
+    // Fail the operation if adding new jobs will cause the queue to reach its capacity limit

Review comment:
       Thanks. I added rollback functionality.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org