You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/09/12 10:58:33 UTC
[jira] Created: (LUCENE-2641) BaseTestRangeFilter can be extremely
slow
BaseTestRangeFilter can be extremely slow
-----------------------------------------
Key: LUCENE-2641
URL: https://issues.apache.org/jira/browse/LUCENE-2641
Project: Lucene - Java
Issue Type: Test
Components: Tests
Reporter: Robert Muir
Fix For: 3.1, 4.0
The tests that extend BaseTestRangeFilter can sometimes be very slow:
TestFieldCacheRangeFilter, TestMultiTermConstantScore, TestTermRangeFilter
for example, TestFieldCacheRangeFilter just ran for 10 minutes on my computer before I killed it,
but i noticed these tests frequently run for over a minute.
I think at the least we should change these to junit4 so the index is built once in @beforeClass
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2641) BaseTestRangeFilter can be extremely
slow
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2641:
--------------------------------
Attachment: LUCENE-2641.patch
sorry! wrong patch. (I accidentally uploaded the old one again last time)
> BaseTestRangeFilter can be extremely slow
> -----------------------------------------
>
> Key: LUCENE-2641
> URL: https://issues.apache.org/jira/browse/LUCENE-2641
> Project: Lucene - Java
> Issue Type: Test
> Components: Tests
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2641.patch, LUCENE-2641.patch, LUCENE-2641.patch
>
>
> The tests that extend BaseTestRangeFilter can sometimes be very slow:
> TestFieldCacheRangeFilter, TestMultiTermConstantScore, TestTermRangeFilter
> for example, TestFieldCacheRangeFilter just ran for 10 minutes on my computer before I killed it,
> but i noticed these tests frequently run for over a minute.
> I think at the least we should change these to junit4 so the index is built once in @beforeClass
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2641) BaseTestRangeFilter can be extremely
slow
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-2641.
---------------------------------
Resolution: Fixed
Committed revision 996357, 996360 (3x).
we can always look out for more tests like this and handle them on a case by case basis,
In general if it creates a huge index, we should ensure reasonable maxBufferedDocs etc,
and if it has a ton of methods that don't modify the index, we should consider creating the index in @BeforeClass
But i think the "crazy" defaults in newIndexWriterConfig are reasonable, given most tests
only use a tiny amount of documents.
> BaseTestRangeFilter can be extremely slow
> -----------------------------------------
>
> Key: LUCENE-2641
> URL: https://issues.apache.org/jira/browse/LUCENE-2641
> Project: Lucene - Java
> Issue Type: Test
> Components: Tests
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2641.patch, LUCENE-2641.patch, LUCENE-2641.patch
>
>
> The tests that extend BaseTestRangeFilter can sometimes be very slow:
> TestFieldCacheRangeFilter, TestMultiTermConstantScore, TestTermRangeFilter
> for example, TestFieldCacheRangeFilter just ran for 10 minutes on my computer before I killed it,
> but i noticed these tests frequently run for over a minute.
> I think at the least we should change these to junit4 so the index is built once in @beforeClass
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2641) BaseTestRangeFilter can be extremely
slow
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2641:
--------------------------------
Attachment: LUCENE-2641.patch
here's an updated patch that speeds up the worst of the tests.
additionally we found 2 bugs in preflex codec that caused tests to be very slow under preflex.
> BaseTestRangeFilter can be extremely slow
> -----------------------------------------
>
> Key: LUCENE-2641
> URL: https://issues.apache.org/jira/browse/LUCENE-2641
> Project: Lucene - Java
> Issue Type: Test
> Components: Tests
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2641.patch, LUCENE-2641.patch
>
>
> The tests that extend BaseTestRangeFilter can sometimes be very slow:
> TestFieldCacheRangeFilter, TestMultiTermConstantScore, TestTermRangeFilter
> for example, TestFieldCacheRangeFilter just ran for 10 minutes on my computer before I killed it,
> but i noticed these tests frequently run for over a minute.
> I think at the least we should change these to junit4 so the index is built once in @beforeClass
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2641) BaseTestRangeFilter can be extremely
slow
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2641:
--------------------------------
Attachment: LUCENE-2641.patch
here's an initial patch.
i tried to fix some worst-case problems with similar tests as well, but some
still have problems...
> BaseTestRangeFilter can be extremely slow
> -----------------------------------------
>
> Key: LUCENE-2641
> URL: https://issues.apache.org/jira/browse/LUCENE-2641
> Project: Lucene - Java
> Issue Type: Test
> Components: Tests
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2641.patch
>
>
> The tests that extend BaseTestRangeFilter can sometimes be very slow:
> TestFieldCacheRangeFilter, TestMultiTermConstantScore, TestTermRangeFilter
> for example, TestFieldCacheRangeFilter just ran for 10 minutes on my computer before I killed it,
> but i noticed these tests frequently run for over a minute.
> I think at the least we should change these to junit4 so the index is built once in @beforeClass
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org