You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/28 09:22:41 UTC

[GitHub] [tvm] lhutton1 commented on a diff in pull request #13487: [ACL] Enable int8 data type in QNN DENSE

lhutton1 commented on code in PR #13487:
URL: https://github.com/apache/tvm/pull/13487#discussion_r1033297838


##########
tests/python/contrib/test_arm_compute_lib/test_dense.py:
##########
@@ -251,7 +252,14 @@ def test_codegen_dense():
         verify_codegen(func, exp_codegen)
 
 
-def test_qnn_dense():
+@pytest.mark.parametrize(
+    "dtype,min_range,max_range",
+    [
+        ("uint8", 0, 255),
+        ("int8", -127, 128),
+    ],
+)

Review Comment:
   +1, I intended to do this for NPU testing as well but never got around to it, perhaps we can pull it out into a bigger refactoring?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org