You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/04/24 01:21:53 UTC
Review Request: Added a Socket reference to Encoder.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10742/
-----------------------------------------------------------
Review request for mesos, Vinod Kone and Ben Mahler.
Description
-------
See summary.
This addresses bug MESOS-300.
https://issues.apache.org/jira/browse/MESOS-300
Diffs
-----
third_party/libprocess/src/encoder.hpp 84e08297d11fc3dc1b040c69290bcc1087628839
third_party/libprocess/src/process.cpp d3dfe806aeb18d495717a07c555bd628d0ee88b7
Diff: https://reviews.apache.org/r/10742/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added a Socket reference to Encoder.
Posted by Tobias Weingartner <tw...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10742/#review19775
-----------------------------------------------------------
third_party/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/10742/#comment40794>
I would check for "-1" explicitly. Then I'd set the socket to "-1" just to make sure nothing else can use it later.
if (close(s) == -1) { ... } else { s = -1; }
- Tobias Weingartner
On April 24, 2013, 7:49 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10742/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 7:49 p.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> This addresses bug MESOS-300.
> https://issues.apache.org/jira/browse/MESOS-300
>
>
> Diffs
> -----
>
> third_party/libprocess/include/process/socket.hpp 147939f85cd83356ae9859ed97daf75bf8c6c685
> third_party/libprocess/src/encoder.hpp 84e08297d11fc3dc1b040c69290bcc1087628839
> third_party/libprocess/src/process.cpp 0a57e8000c3cb9e37aacb485b78a58ba32c7c0ed
>
> Diff: https://reviews.apache.org/r/10742/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added a Socket reference to Encoder.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10742/
-----------------------------------------------------------
(Updated April 24, 2013, 7:49 p.m.)
Review request for mesos, Vinod Kone and Ben Mahler.
Changes
-------
Changed construction of Socket instances to be explicit to avoid implicit casts to int followed by implicit constructions of Socket (thus creating two separate "owning" instances of a socket file descriptor, possibly leading to close being called twice).
Description
-------
See summary.
This addresses bug MESOS-300.
https://issues.apache.org/jira/browse/MESOS-300
Diffs (updated)
-----
third_party/libprocess/include/process/socket.hpp 147939f85cd83356ae9859ed97daf75bf8c6c685
third_party/libprocess/src/encoder.hpp 84e08297d11fc3dc1b040c69290bcc1087628839
third_party/libprocess/src/process.cpp 0a57e8000c3cb9e37aacb485b78a58ba32c7c0ed
Diff: https://reviews.apache.org/r/10742/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added a Socket reference to Encoder.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10742/#review19609
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 23, 2013, 11:21 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10742/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 11:21 p.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> This addresses bug MESOS-300.
> https://issues.apache.org/jira/browse/MESOS-300
>
>
> Diffs
> -----
>
> third_party/libprocess/src/encoder.hpp 84e08297d11fc3dc1b040c69290bcc1087628839
> third_party/libprocess/src/process.cpp d3dfe806aeb18d495717a07c555bd628d0ee88b7
>
> Diff: https://reviews.apache.org/r/10742/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added a Socket reference to Encoder.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10742/#review19608
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On April 23, 2013, 11:21 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10742/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 11:21 p.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> This addresses bug MESOS-300.
> https://issues.apache.org/jira/browse/MESOS-300
>
>
> Diffs
> -----
>
> third_party/libprocess/src/encoder.hpp 84e08297d11fc3dc1b040c69290bcc1087628839
> third_party/libprocess/src/process.cpp d3dfe806aeb18d495717a07c555bd628d0ee88b7
>
> Diff: https://reviews.apache.org/r/10742/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>