You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/01 15:51:20 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #13765: ARROW-17272: [Dev] Pass --add-opens in integration tests
lidavidm opened a new pull request, #13765:
URL: https://github.com/apache/arrow/pull/13765
This affects Java 16+ due to JEP 396 which now forces us to pass `--add-opens`. Detect the presence of Java >8 and pass the flag in the integration runner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13765: ARROW-17272: [Dev] Pass --add-opens in integration tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13765:
URL: https://github.com/apache/arrow/pull/13765#issuecomment-1201382925
https://issues.apache.org/jira/browse/ARROW-17272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #13765: ARROW-17272: [Dev] Pass --add-opens in integration tests
Posted by GitBox <gi...@apache.org>.
kou merged PR #13765:
URL: https://github.com/apache/arrow/pull/13765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13765: ARROW-17272: [Dev] Pass --add-opens in integration tests
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13765:
URL: https://github.com/apache/arrow/pull/13765#issuecomment-1201904309
Benchmark runs are scheduled for baseline = c5173186bbd61641ba05e2848ad860fb696f6095 and contender = e80981ca2a7b8c43f61f41b55842423b8295d633. e80981ca2a7b8c43f61f41b55842423b8295d633 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1641f52afad441bd8510d081cf990d39...ef476dc00c34459196b601daff962028/)
[Finished :arrow_down:0.07% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/bc35e07e998744b6a92bbb19bc9f5c5d...09b2930d81b24200bcc2e9a91f041626/)
[Finished :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d9f215d600eb4ed3a5646423ec20b526...a0e9d31325994914b1bf6d4a728a2e6c/)
[Finished :arrow_down:0.04% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2cec65892d1a42278c08acf9bea4bdf0...44a442742147434d96b1ce70168c814f/)
Buildkite builds:
[Failed] [`e80981ca` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1237)
[Finished] [`e80981ca` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1249)
[Finished] [`e80981ca` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1231)
[Finished] [`e80981ca` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1251)
[Failed] [`c5173186` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1236)
[Finished] [`c5173186` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1248)
[Finished] [`c5173186` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1230)
[Finished] [`c5173186` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1250)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13765: ARROW-17272: [Dev] Pass --add-opens in integration tests
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13765:
URL: https://github.com/apache/arrow/pull/13765#issuecomment-1201465949
I'd probably lean towards it being overkill. Unless it can be done inside the existing job somehow, to avoid rebuilding everything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org