You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/05 00:50:13 UTC

[GitHub] [eventmesh] pandaapo opened a new pull request, #3869: [ISSUE #3868]Method buildCloudEventPropertyKey() in CloudEventUtils return a param immediately

pandaapo opened a new pull request, #3869:
URL: https://github.com/apache/eventmesh/pull/3869

   Fixes #3868.
   
   ### Motivation
   
   See "Enhancement Request" in [issue](https://github.com/apache/eventmesh/issues/3868#issue-1696862806).
   
   
   
   ### Modifications
   
   See "Describe the solution you'd like" in [issue](https://github.com/apache/eventmesh/issues/3868#issue-1696862806).
   
   
   
   ### Documentation
   
   - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [eventmesh] xwm1992 merged pull request #3869: [ISSUE #3868]Method buildCloudEventPropertyKey() in CloudEventUtils return a param immediately

Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3869:
URL: https://github.com/apache/eventmesh/pull/3869


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [eventmesh] codecov[bot] commented on pull request #3869: [ISSUE #3868]Method buildCloudEventPropertyKey() in CloudEventUtils return a param immediately

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3869:
URL: https://github.com/apache/eventmesh/pull/3869#issuecomment-1535832050

   ## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3869?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3869](https://app.codecov.io/gh/apache/eventmesh/pull/3869?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e1af60) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/c5b7cf44e526f01016e2f05af7fde3e7c0534462?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5b7cf4) will **decrease** coverage by `0.03%`.
   > The diff coverage is `72.72%`.
   
   > :exclamation: Current head 9e1af60 differs from pull request most recent head a2e5911. Consider uploading reports for the commit a2e5911 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3869      +/-   ##
   ============================================
   - Coverage     13.81%   13.79%   -0.03%     
   + Complexity     1291     1290       -1     
   ============================================
     Files           571      571              
     Lines         29090    29076      -14     
     Branches       2841     2829      -12     
   ============================================
   - Hits           4019     4010       -9     
   + Misses        24698    24694       -4     
   + Partials        373      372       -1     
   ```
   
   
   | [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ntmesh/storage/rocketmq/utils/CloudEventUtils.java](https://app.codecov.io/gh/apache/eventmesh/pull/3869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvc3RvcmFnZS9yb2NrZXRtcS91dGlscy9DbG91ZEV2ZW50VXRpbHMuamF2YQ==) | `47.27% <72.72%> (-2.73%)` | :arrow_down: |
   
   ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3869/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org