[jira] [Commented] (AVRO-2051) Thread contention accessing JsonProperties props

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678511#comment-16678511 ] 

ASF subversion and git services commented on AVRO-2051:
-------------------------------------------------------

Commit a318a34d1f5f8146fb441c092c73b6170719e88a in avro's branch refs/heads/master from [~dkulp]
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=a318a34 ]

[AVRO-2051] Remove synchronization for JsonProperties.getJsonProp
Fixes #245


> Thread contention accessing JsonProperties props
> ------------------------------------------------
>
>                 Key: AVRO-2051
>                 URL: https://issues.apache.org/jira/browse/AVRO-2051
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.8.2
>            Reporter: Daniel Kulp
>            Priority: Major
>
> See https://lists.apache.org/thread.html/dd34ab8439137a81a9de29ad4161f37b17638394cea0806765689976@%3Cuser.avro.apache.org%3E
> Basically, the getJsonProp method, being synchronized, is causing thread contention issues when trying to share schemas between threads.    My proposal (pull request forthcoming) is to treat "props" as an immutable map and do a copy+add+swap for the addProp method.   This will make the addProp call slower (particularly for large maps of props), but would make the reads significantly faster as no locking will be needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)