You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sarangan12 <gi...@git.apache.org> on 2016/01/27 20:12:38 UTC
[GitHub] cordova-docs pull request: CB-10294: Wrong link in docs
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-docs/pull/469
CB-10294: Wrong link in docs
Fixed one wrong link in docs and also changed the links to reference links.
@dblotsky @riknoll @nikhilkh @rakatyal Can you please review and merge this PR?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarangan12/cordova-docs CB-10294
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/469.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #469
----
commit 1d0455db7e391fa37a8a4d0b37c65fa5e066685e
Author: Sarangan Rajamanickam <sa...@microsoft.com>
Date: 2016-01-27T19:10:39Z
CB-10294: Wrong link in docs
Fixed one wrong link in docs and also changed the links to reference
links.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10294: Wrong link in docs
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10294: Wrong link in docs
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/469#issuecomment-175825801
Okay great. Thanks. And this looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10294: Wrong link in docs
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/469#issuecomment-175819723
@riknoll Addressed the comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10294: Wrong link in docs
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/469#discussion_r51036871
--- Diff: www/docs/en/dev/cordova/storage/storage.md ---
@@ -64,6 +62,12 @@ The following platforms support IndexedDB:
## Plugin-Based Options
In addition to the storage APIs listed above, the
-[File API](https://github.com/apache/cordova-plugin-file/blob/master/doc/index.md)
-allows you to cache data on the local file system. Other
-[Cordova plugins](http://plugins.cordova.io/) provide similar storage options.
+[File API][FileAPI] allows you to cache data on the local file system. Other
+[Cordova plugins][Cordovaplugins] provide similar storage options.
+
+[Html5RocksStorage]: http://www.html5rocks.com/en/features/storage
+[W3CSpecStorage]: http://www.w3.org/TR/webstorage/
+[WebSQLDatabaseSpecification]: http://dev.w3.org/html5/webdatabase/
+[IndexedDB]: http://www.w3.org/TR/IndexedDB/
+[FileAPI]: https://github.com/apache/cordova-plugin-file/blob/master/README.md
+[Cordovaplugins]: /plugins
--- End diff --
Also maybe capitalize the 'p'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10294: Wrong link in docs
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/469#issuecomment-175813525
Are you using 'checklinks' gulp task to find these broken links? I believe we have [this] (https://issues.apache.org/jira/browse/CB-10058) Jira to fix the broken links.
@dblotsky, @riknoll : I believe we still have the checklinks task in our gulpfile?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10294: Wrong link in docs
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/469#discussion_r51036646
--- Diff: www/docs/en/dev/cordova/storage/storage.md ---
@@ -64,6 +62,12 @@ The following platforms support IndexedDB:
## Plugin-Based Options
In addition to the storage APIs listed above, the
-[File API](https://github.com/apache/cordova-plugin-file/blob/master/doc/index.md)
-allows you to cache data on the local file system. Other
-[Cordova plugins](http://plugins.cordova.io/) provide similar storage options.
+[File API][FileAPI] allows you to cache data on the local file system. Other
+[Cordova plugins][Cordovaplugins] provide similar storage options.
+
+[Html5RocksStorage]: http://www.html5rocks.com/en/features/storage
+[W3CSpecStorage]: http://www.w3.org/TR/webstorage/
+[WebSQLDatabaseSpecification]: http://dev.w3.org/html5/webdatabase/
+[IndexedDB]: http://www.w3.org/TR/IndexedDB/
+[FileAPI]: https://github.com/apache/cordova-plugin-file/blob/master/README.md
+[Cordovaplugins]: /plugins
--- End diff --
This link should use `{{ site.baseurl }}`. That is,
```
[Cordovaplugins]: {{ site.baseurl }}/plugins
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10294: Wrong link in docs
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/469#issuecomment-175821302
@rakatyal These broken links are found using the JIRA tickets created. At this point, I did check the 'checklinks' task. It does not work with all cases. I am planning to take a look at it soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org