You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/08/08 04:38:06 UTC
[GitHub] [yunikorn-k8shim] wilfred-s opened a new pull request, #447: [YUNIKORN-1256] license issues in deployments examples
wilfred-s opened a new pull request, #447:
URL: https://github.com/apache/yunikorn-k8shim/pull/447
### What is this PR for?
In the k8shim the tfjob contains files that are not part of Apache. The
LICENSE file should show this. It also should show correctly in the
source release and be merged as part of the release build.
Fixing license issues:
- inconsistent formatting (line endings and empty lines)
- missing license in two k8shim files
- update make target to cover new dile types
### What type of PR is it?
* [X] - Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1256
### How should this be tested?
build locally and ran all updated make targets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #447: [YUNIKORN-1256] license issues in deployments examples
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #447:
URL: https://github.com/apache/yunikorn-k8shim/pull/447#issuecomment-1207661736
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/447?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#447](https://codecov.io/gh/apache/yunikorn-k8shim/pull/447?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cf2675e) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/b452573792f572fe798ee27f3995f6d7f0be2b7c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b452573) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #447 +/- ##
==========================================
- Coverage 67.34% 67.29% -0.06%
==========================================
Files 41 41
Lines 6744 6739 -5
==========================================
- Hits 4542 4535 -7
- Misses 2032 2034 +2
Partials 170 170
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/447/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `74.82% <0.00%> (-1.40%)` | :arrow_down: |
| [pkg/plugin/predicates/predicate\_manager.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/447/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9wcmVkaWNhdGVzL3ByZWRpY2F0ZV9tYW5hZ2VyLmdv) | `50.19% <0.00%> (-0.96%)` | :arrow_down: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #447: [YUNIKORN-1256] license issues in deployments examples
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #447: [YUNIKORN-1256] license issues in deployments examples
URL: https://github.com/apache/yunikorn-k8shim/pull/447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org