You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hc.apache.org by "Kaven Stone (Jira)" <ji...@apache.org> on 2021/10/17 04:03:00 UTC

[jira] [Closed] (HTTPCORE-688) DefaultH2RequestConverter is design as singleton but not set the constructor method as private

     [ https://issues.apache.org/jira/browse/HTTPCORE-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kaven Stone closed HTTPCORE-688.
--------------------------------

the public construct method have no harm, and consider the binary compatibility, it's better do nothting for it.

> DefaultH2RequestConverter is design as singleton but not set the constructor method as private
> ----------------------------------------------------------------------------------------------
>
>                 Key: HTTPCORE-688
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-688
>             Project: HttpComponents HttpCore
>          Issue Type: Wish
>          Components: HttpCore
>    Affects Versions: 5.0
>            Reporter: Kaven Stone
>            Priority: Trivial
>
> DefaultH2RequestConverter is design as singleton but not set the constructor method as private. The same with DefaultH2ResponseConverter.
> Is it better to set the method as private ?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org