You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/25 10:25:02 UTC
[GitHub] [arrow] jinchengchenghh opened a new pull request, #13969: [ARROW-17523] Add support to substrait function is_null, is_not_null and count
jinchengchenghh opened a new pull request, #13969:
URL: https://github.com/apache/arrow/pull/13969
https://github.com/apache/arrow/pull/13613 supports some functions, this PR add more standard functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #13969: [ARROW-17523] Add support to substrait function is_null, is_not_null and count
Posted by GitBox <gi...@apache.org>.
westonpace commented on PR #13969:
URL: https://github.com/apache/arrow/pull/13969#issuecomment-1227867544
The lint error appears valid as well. Please run clang-format on the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13969: ARROW-17523: [C++] Add support to substrait function is_null, is_not_null and count
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13969:
URL: https://github.com/apache/arrow/pull/13969#issuecomment-1231902835
:warning: Ticket **has no components in JIRA**, make sure you assign one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13969: [ARROW-17523] Add support to substrait function is_null, is_not_null and count
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13969:
URL: https://github.com/apache/arrow/pull/13969#issuecomment-1227410582
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13969: ARROW-17523: [C++] Add support to substrait function is_null, is_not_null and count
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13969:
URL: https://github.com/apache/arrow/pull/13969#issuecomment-1232311213
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a65b7abf2f454c848d8db956329838dd...33a21a3675cb452b8d1aa3ef1df2c9a8/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a diff in pull request #13969: [ARROW-17523] Add support to substrait function is_null, is_not_null and count
Posted by GitBox <gi...@apache.org>.
westonpace commented on code in PR #13969:
URL: https://github.com/apache/arrow/pull/13969#discussion_r955506618
##########
cpp/src/arrow/engine/substrait/function_test.cc:
##########
@@ -487,7 +497,13 @@ TEST(FunctionMapping, AggregateCases) {
float64(),
"[2]",
"[1.5, 3]",
- float64()}};
+ float64()},
+ {{kSubstraitAggregateGenericFunctionsUri, "count"},
+ {"[1, 2, 30]"},
+ {int8()},
+ "[3]",
+ "[2, 1]",
+ int64()}};
Review Comment:
Unfortunately, the count function takes in a [single optional enum argument](https://github.com/substrait-io/substrait/blob/main/extensions/functions_aggregate_generic.yaml#L8). I have no idea what the purpose of this argument is. However, in Substrait, "optional arguments" should still be included in the protobuf.
I realize now that I did not account for this in the other aggregate functions too :(.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13969: ARROW-17523: [C++] Add support to substrait function is_null, is_not_null and count
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13969:
URL: https://github.com/apache/arrow/pull/13969#issuecomment-1231902812
https://issues.apache.org/jira/browse/ARROW-17523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #13969: ARROW-17523: [C++] Add support to substrait function is_null, is_not_null and count
Posted by GitBox <gi...@apache.org>.
westonpace commented on PR #13969:
URL: https://github.com/apache/arrow/pull/13969#issuecomment-1231828861
Thanks @jinchengchenghh . I updated the title of the PR to conform to our style and I changed the description a little (since this is used for the git commit) and merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace merged pull request #13969: ARROW-17523: [C++] Add support to substrait function is_null, is_not_null and count
Posted by GitBox <gi...@apache.org>.
westonpace merged PR #13969:
URL: https://github.com/apache/arrow/pull/13969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jinchengchenghh commented on a diff in pull request #13969: [ARROW-17523] Add support to substrait function is_null, is_not_null and count
Posted by GitBox <gi...@apache.org>.
jinchengchenghh commented on code in PR #13969:
URL: https://github.com/apache/arrow/pull/13969#discussion_r955578816
##########
cpp/src/arrow/engine/substrait/function_test.cc:
##########
@@ -487,7 +497,13 @@ TEST(FunctionMapping, AggregateCases) {
float64(),
"[2]",
"[1.5, 3]",
- float64()}};
+ float64()},
+ {{kSubstraitAggregateGenericFunctionsUri, "count"},
+ {"[1, 2, 30]"},
+ {int8()},
+ "[3]",
+ "[2, 1]",
+ int64()}};
Review Comment:
I'm new to substrait. Maybe it means the enumeration arguments.
https://github.com/substrait-io/substrait/blob/main/text/simple_extensions_schema.yaml#L94
And here may have some clue https://substrait.io/expressions/scalar_functions/#optional-enumeration-properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jinchengchenghh commented on pull request #13969: [ARROW-17523] Add support to substrait function is_null, is_not_null and count
Posted by GitBox <gi...@apache.org>.
jinchengchenghh commented on PR #13969:
URL: https://github.com/apache/arrow/pull/13969#issuecomment-1229638758
Fixed code style.
Can this one merge? @westonpace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jinchengchenghh commented on pull request #13969: ARROW-17523: [C++] Add support to substrait function is_null, is_not_null and count
Posted by GitBox <gi...@apache.org>.
jinchengchenghh commented on PR #13969:
URL: https://github.com/apache/arrow/pull/13969#issuecomment-1244840476
Thanks! It's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13969: ARROW-17523: [C++] Add support to substrait function is_null, is_not_null and count
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13969:
URL: https://github.com/apache/arrow/pull/13969#issuecomment-1232310962
Benchmark runs are scheduled for baseline = e48afd674552a33eacf860533e5b6c25eca547c6 and contender = 74dae618ed8d6b492bf3b88e3b9b7dfd4c21e8d8. 74dae618ed8d6b492bf3b88e3b9b7dfd4c21e8d8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4d72c419a12d4407af619ff09eb3b5a6...79c97e7eeeb4412daa7c3fd1dc957e05/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/87b19ed5c3764665a588c1546466f4e7...307c8f08fd2c43fa864c65c370139f9b/)
[Failed :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a65b7abf2f454c848d8db956329838dd...33a21a3675cb452b8d1aa3ef1df2c9a8/)
[Finished :arrow_down:0.14% :arrow_up:0.11%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c45aa2739a984ab4b3560ddb700a1e35...7dcf7209a755414e9d86c32e33e87b0b/)
Buildkite builds:
[Finished] [`74dae618` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1389)
[Failed] [`74dae618` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1405)
[Failed] [`74dae618` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1387)
[Finished] [`74dae618` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1404)
[Finished] [`e48afd67` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1388)
[Failed] [`e48afd67` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1404)
[Failed] [`e48afd67` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1386)
[Finished] [`e48afd67` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1403)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org