You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/07/30 09:57:26 UTC

[GitHub] carbondata pull request #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in q...

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2580

    [CARBONDATA-2799][BloomDataMap] Fix bugs in querying with bloom datamap on preagg with dictionary column

    For preaggregate table, if the groupby column is dictionary column in
    parent table, the preaggregate table will inherit the dictionary
    encoding as well as the dictionary file from the parent table.
    
    So for dictionary columns, during query with bloom, we need to
    convert the plain filter value to dictionarty encoded value based on
    parent table's dictionary file.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [x] Any interfaces changed?
     `NO`
     - [x] Any backward compatibility impacted?
      `NO`
     - [x] Document update required?
     `NO`
     - [x] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
    `Added test`
            - How it is tested? Please attach test report.
    `Tested in local machine`
            - Is it a performance related change? Please attach the performance test report.
    `NO`
            - Any additional information to help reviewers in testing this change.
           `NA`
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    `NA`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0730_bug_bloom_preagg

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2580
    
----
commit c097efac3732f145f1af2bef9274d571d20ebad0
Author: xuchuanyin <xu...@...>
Date:   2018-07-30T09:50:51Z

    Fix bugs in querying with bloom datamap on preagg with dictionary column
    
    For preaggregate table, if the groupby column is dictionary column in
    parent table, the preaggregate table will inherit the dictionary
    encoding as well as the dictionary file from the parent table.
    
    So for dictionary columns, during query with bloom, we need to
    convert the plain filter value to dictionarty encoded value based on
    parent table's dictionary file.

----


---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6092/



---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by xuchuanyin <gi...@git.apache.org>.

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    retest this please


---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7647/



---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by xuchuanyin <gi...@git.apache.org>.

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    retest it please


---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7671/



---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by jackylk <gi...@git.apache.org>.

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    LGTM


---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by xuchuanyin <gi...@git.apache.org>.

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    fix confilicts


---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6423/



---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6356/



---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6453/



---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by brijoobopanna <gi...@git.apache.org>.

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    retest sdv please



---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6120/



---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6376/



---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by brijoobopanna <gi...@git.apache.org>.

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    retest this please


---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6401/



---

[GitHub] carbondata issue #2580: [CARBONDATA-2799][BloomDataMap] Fix bugs in querying...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2580
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7697/



---