You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Erin Noe-Payne <er...@mitre.org> on 2012/08/07 21:12:41 UTC
Review Request: RAVE-751: Add client side concept of page owner and viewer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6444/
-----------------------------------------------------------
Review request for rave.
Description
-------
Adds the concept of page viewer and owner to the client at the container level. Page viewer is defined as the authenticated user viewing a page, owner is left to be defined on a per-page basis.
This addresses bug RAVE-751.
https://issues.apache.org/jira/browse/RAVE-751
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1370376
trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag 1370376
trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1370376
Diff: https://reviews.apache.org/r/6444/diff/
Testing
-------
Thanks,
Erin Noe-Payne
Re: Review Request: RAVE-751: Add client side concept of page owner and
viewer
Posted by Erin Noe-Payne <er...@mitre.org>.
> On Aug. 7, 2012, 10:06 p.m., Chris Geer wrote:
> > trunk/rave-portal-resources/src/main/webapp/static/script/rave.js, line 1287
> > <https://reviews.apache.org/r/6444/diff/1/?file=135322#file135322line1287>
> >
> > Does it make sense to update the documentation here to describe the expected/returned object?
I think no? First, that's not consistent with all of the other documentation comments in the file. Second, this is providing a reference implementation, but the pageOwner / pageViewer objects could contain any custom object based on the user implementation.
- Erin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6444/#review9993
-----------------------------------------------------------
On Aug. 8, 2012, 1:15 p.m., Erin Noe-Payne wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6444/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2012, 1:15 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Adds the concept of page viewer and owner to the client at the container level. Page viewer is defined as the authenticated user viewing a page, owner is left to be defined on a per-page basis.
>
>
> This addresses bug RAVE-751.
> https://issues.apache.org/jira/browse/RAVE-751
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1370376
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag 1370376
> trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1370376
>
> Diff: https://reviews.apache.org/r/6444/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erin Noe-Payne
>
>
Re: Review Request: RAVE-751: Add client side concept of page owner and
viewer
Posted by Chris Geer <ch...@cxtsoftware.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6444/#review9993
-----------------------------------------------------------
trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag
<https://reviews.apache.org/r/6444/#comment21167>
Minor nit, just fix the indenting to show these statements happen within the context of the <sec:authorize>
trunk/rave-portal-resources/src/main/webapp/static/script/rave.js
<https://reviews.apache.org/r/6444/#comment21170>
Since pageOwner is currently only set on the profile page, would it be better to return a valid default object like {username: "Unknown", id:"-1"} or something rather than undefined/null?
trunk/rave-portal-resources/src/main/webapp/static/script/rave.js
<https://reviews.apache.org/r/6444/#comment21168>
I would prefer to see the method name match the variable so setViewer becomes setPageViewer (same change on other method names.
trunk/rave-portal-resources/src/main/webapp/static/script/rave.js
<https://reviews.apache.org/r/6444/#comment21169>
Does it make sense to update the documentation here to describe the expected/returned object?
- Chris Geer
On Aug. 7, 2012, 7:12 p.m., Erin Noe-Payne wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6444/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2012, 7:12 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Adds the concept of page viewer and owner to the client at the container level. Page viewer is defined as the authenticated user viewing a page, owner is left to be defined on a per-page basis.
>
>
> This addresses bug RAVE-751.
> https://issues.apache.org/jira/browse/RAVE-751
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1370376
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag 1370376
> trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1370376
>
> Diff: https://reviews.apache.org/r/6444/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erin Noe-Payne
>
>
Re: Review Request: RAVE-751: Add client side concept of page owner and
viewer
Posted by Chris Geer <ch...@cxtsoftware.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6444/#review10022
-----------------------------------------------------------
Ship it!
Looks good. If you can update the JIRA ticket with the latest patch I'll commit today.
- Chris Geer
On Aug. 8, 2012, 1:15 p.m., Erin Noe-Payne wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6444/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2012, 1:15 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Adds the concept of page viewer and owner to the client at the container level. Page viewer is defined as the authenticated user viewing a page, owner is left to be defined on a per-page basis.
>
>
> This addresses bug RAVE-751.
> https://issues.apache.org/jira/browse/RAVE-751
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1370376
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag 1370376
> trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1370376
>
> Diff: https://reviews.apache.org/r/6444/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erin Noe-Payne
>
>
Re: Review Request: RAVE-751: Add client side concept of page owner and
viewer
Posted by Erin Noe-Payne <er...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6444/
-----------------------------------------------------------
(Updated Aug. 8, 2012, 1:15 p.m.)
Review request for rave.
Changes
-------
Updated based on Chris Geer's feedback. Thanks Chris!
Description
-------
Adds the concept of page viewer and owner to the client at the container level. Page viewer is defined as the authenticated user viewing a page, owner is left to be defined on a per-page basis.
This addresses bug RAVE-751.
https://issues.apache.org/jira/browse/RAVE-751
Diffs (updated)
-----
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1370376
trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag 1370376
trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1370376
Diff: https://reviews.apache.org/r/6444/diff/
Testing
-------
Thanks,
Erin Noe-Payne