You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/07/10 17:23:54 UTC

[GitHub] flink issue #3511: [Flink-5734] code generation for normalizedkey sorter

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/3511
  
    @heytitle apologies for the long delay. I've been working to improve the Gelly examples to process with each of the standard data types (from byte to string). I think we can validate both the correctness and performance of this PR in time for the 1.4 release.
    
    Are you able to continue working on this feature? There are several steps to proceed with:
    - rebase to master
    - fix checkstyle warnings against the new "strict checkstyle"
    - implement code generation for `FixedLengthRecordSorter`
    
    Rather than extending `NormalizedKeySorter`, we could pull the compare and swap functions out of `MemorySegment` into an interface with a default implementation moved from `NormalizedKeySorter` and `FixedLengthRecordSorter`. There is overlap in that the `normalizedKeyFullyDetermines` case of `NormalizedKeySorter` results in the same operations as in `FixedLengthRecordSorter`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---