You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2023/09/28 06:52:54 UTC
[GitHub] [incubator-celeborn] cxzl25 opened a new pull request, #1945: [CELEBORN-1013] Shutdown master if initialized failed
cxzl25 opened a new pull request, #1945:
URL: https://github.com/apache/incubator-celeborn/pull/1945
### What changes were proposed in this pull request?
For example, bind's http service port(`celeborn.metrics.master.prometheus.port`) port is occupied and master startup fails, but because the thread started by Raft is not a daemon, the master process still exists.
```java
23/09/28 14:48:12,512 ERROR [main] Master: Initialize master failed.
java.net.BindException: Address already in use
at sun.nio.ch.Net.bind0(Native Method)
at sun.nio.ch.Net.bind(Net.java:461)
at sun.nio.ch.Net.bind(Net.java:453)
at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:222)
at io.netty.channel.socket.nio.NioServerSocketChannel.doBind(NioServerSocketChannel.java:141)
at io.netty.channel.AbstractChannel$AbstractUnsafe.bind(AbstractChannel.java:562)
at io.netty.channel.DefaultChannelPipeline$HeadContext.bind(DefaultChannelPipeline.java:1334)
```
https://github.com/apache/ratis/blob/d461a01a53e7e130f0ec4143e75b316012137b62/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java#L283-L290
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1945: [CELEBORN-1013] Shutdown master if initialized failed
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1945:
URL: https://github.com/apache/incubator-celeborn/pull/1945#issuecomment-1738595551
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1945?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1945](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1945?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4156abc) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/ef4fc51d5f2d9d1a707e06cac2c64f3a07082e42?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ef4fc51) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1945 +/- ##
=======================================
Coverage 46.37% 46.37%
=======================================
Files 164 164
Lines 10341 10341
Branches 953 953
=======================================
Hits 4795 4795
Misses 5230 5230
Partials 316 316
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1945: [CELEBORN-1013] Shutdown master if initialized failed
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1945:
URL: https://github.com/apache/incubator-celeborn/pull/1945#issuecomment-1738933854
Merged to main/0.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1945: [CELEBORN-1013] Shutdown master if initialized failed
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1945:
URL: https://github.com/apache/incubator-celeborn/pull/1945#issuecomment-1738932345
> ... the thread started by Raft is not a daemon ...
is it configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cxzl25 commented on pull request #1945: [CELEBORN-1013] Shutdown master if initialized failed
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on PR #1945:
URL: https://github.com/apache/incubator-celeborn/pull/1945#issuecomment-1738981738
> > ... the thread started by Raft is not a daemon ...
>
> is it configurable?
Looking at the source code for ratis, there is no support for configuring a thread factory with a daemon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1945: [CELEBORN-1013] Shutdown master if initialized failed
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1945: [CELEBORN-1013] Shutdown master if initialized failed
URL: https://github.com/apache/incubator-celeborn/pull/1945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org