You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@solr.apache.org by ds...@apache.org on 2024/03/20 04:40:03 UTC

(solr) branch main updated: SOLR-16403: Fix DeleteShardTest (#2359)

This is an automated email from the ASF dual-hosted git repository.

dsmiley pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/solr.git


The following commit(s) were added to refs/heads/main by this push:
     new f56db508e25 SOLR-16403: Fix DeleteShardTest (#2359)
f56db508e25 is described below

commit f56db508e25035309e58e60e75ecbc5ac75ef278
Author: pjmcarthur <92...@users.noreply.github.com>
AuthorDate: Tue Mar 19 21:39:57 2024 -0700

    SOLR-16403: Fix DeleteShardTest (#2359)
    
    Simple mistake; test failed sometimes
    
    Co-authored-by: Paul McArthur <pm...@proton.me>
---
 solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java b/solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java
index 91ab353be1b..f363bb58068 100644
--- a/solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java
@@ -63,7 +63,7 @@ public class DeleteShardTest extends SolrCloudTestCase {
             CollectionAdminRequest.deleteShard(collection, "shard1")
                 .process(cluster.getSolrClient()));
 
-    ShardTestUtil.setSliceState(cluster, collection, "shard1", Slice.State.INACTIVE);
+    setSliceState(collection, "shard1", Slice.State.INACTIVE);
 
     // Can delete an INACTIVE shard
     CollectionAdminRequest.deleteShard(collection, "shard1").process(cluster.getSolrClient());
@@ -71,7 +71,7 @@ public class DeleteShardTest extends SolrCloudTestCase {
         "Expected 'shard1' to be removed", collection, (n, c) -> c.getSlice("shard1") == null);
 
     // Can delete a shard under construction
-    ShardTestUtil.setSliceState(cluster, collection, "shard2", Slice.State.CONSTRUCTION);
+    setSliceState(collection, "shard2", Slice.State.CONSTRUCTION);
     CollectionAdminRequest.deleteShard(collection, "shard2").process(cluster.getSolrClient());
     waitForState(
         "Expected 'shard2' to be removed", collection, (n, c) -> c.getSlice("shard2") == null);