You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by GitBox <gi...@apache.org> on 2021/04/23 00:20:52 UTC

[GitHub] [poi] aschott-looker opened a new pull request #235: Fix date formatting for number cell values

aschott-looker opened a new pull request #235:
URL: https://github.com/apache/poi/pull/235


   * Numbers are not supported correctly in POI nor are they tested. Excel interprets numbers as fractional days since `1/1/1900` or `1/4/1900` depending on your settings. The fix here was to convert fractional days to milliseconds and round up in a way that is consistent with Excel.
   * I added a new spreadsheet with tests that verify rounding and no rounding cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[GitHub] [poi] asfgit closed pull request #235: Fix date formatting for number cell values

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #235:
URL: https://github.com/apache/poi/pull/235


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[GitHub] [poi] asfgit closed pull request #235: Fix date formatting for number cell values

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #235:
URL: https://github.com/apache/poi/pull/235


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[GitHub] [poi] pjfanning commented on pull request #235: Fix date formatting for number cell values

Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #235:
URL: https://github.com/apache/poi/pull/235#issuecomment-826371928


   thanks - merged using https://github.com/apache/poi/commit/50cfe3c10ed4dbee2d9b066d78e5fedf01921e4e


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[GitHub] [poi] pjfanning commented on pull request #235: Fix date formatting for number cell values

Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #235:
URL: https://github.com/apache/poi/pull/235#issuecomment-826371928


   thanks - merged using https://github.com/apache/poi/commit/50cfe3c10ed4dbee2d9b066d78e5fedf01921e4e


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org