You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2015/01/13 00:25:43 UTC

Review Request 29828: Patch ResourceManager into OSS Aurora.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29828/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen and Kevin Sweeney.


Bugs: AURORA-1002
    https://issues.apache.org/jira/browse/AURORA-1002


Repository: aurora


Description
-------

Patch ResourceManager into OSS Aurora.


Diffs
-----

  src/main/python/apache/aurora/executor/bin/BUILD 0434c7ba480a80a9722e626775cf5c3adbc3e68e 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
  src/main/python/apache/aurora/executor/common/BUILD 142ec0d42b2cb31dcef1e32768e9ea5286355913 
  src/main/python/apache/aurora/executor/common/resource_manager.py PRE-CREATION 
  src/test/python/apache/aurora/executor/common/BUILD 2bf6b2df4761acaa88c38868f03e686ec6b42ab7 
  src/test/python/apache/aurora/executor/common/test_resource_manager.py PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py PRE-CREATION 

Diff: https://reviews.apache.org/r/29828/diff/


Testing
-------

Ran e2e v1 tests which broke, but not because of the RM wiring.  Running e2e2 tests now.


Thanks,

Brian Wickman


Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29828/#review67749
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Cohen


On Jan. 12, 2015, 11:40 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29828/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 11:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1002
>     https://issues.apache.org/jira/browse/AURORA-1002
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Patch ResourceManager into OSS Aurora.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 0434c7ba480a80a9722e626775cf5c3adbc3e68e 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
>   src/main/python/apache/aurora/executor/common/BUILD 142ec0d42b2cb31dcef1e32768e9ea5286355913 
>   src/main/python/apache/aurora/executor/common/resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/BUILD 2bf6b2df4761acaa88c38868f03e686ec6b42ab7 
>   src/test/python/apache/aurora/executor/common/test_resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29828/diff/
> 
> 
> Testing
> -------
> 
> Ran e2e v1 tests which broke, but not because of the RM wiring.  Running e2e2 tests now.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29828/
-----------------------------------------------------------

(Updated Jan. 13, 2015, 12:42 a.m.)


Review request for Aurora, Joshua Cohen and Kevin Sweeney.


Changes
-------

Fix missing dep caught by e2e


Bugs: AURORA-1002
    https://issues.apache.org/jira/browse/AURORA-1002


Repository: aurora


Description
-------

Patch ResourceManager into OSS Aurora.


Diffs (updated)
-----

  src/main/python/apache/aurora/executor/bin/BUILD 0434c7ba480a80a9722e626775cf5c3adbc3e68e 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
  src/main/python/apache/aurora/executor/common/BUILD 142ec0d42b2cb31dcef1e32768e9ea5286355913 
  src/main/python/apache/aurora/executor/common/resource_manager.py PRE-CREATION 
  src/test/python/apache/aurora/executor/common/BUILD 2bf6b2df4761acaa88c38868f03e686ec6b42ab7 
  src/test/python/apache/aurora/executor/common/test_resource_manager.py PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py PRE-CREATION 

Diff: https://reviews.apache.org/r/29828/diff/


Testing
-------

Ran e2e v1 tests which broke, but not because of the RM wiring.  Running e2e2 tests now.


Thanks,

Brian Wickman


Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29828/#review67762
-----------------------------------------------------------

Ship it!


Master (5ce076b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 13, 2015, 12:09 a.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29828/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 12:09 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1002
>     https://issues.apache.org/jira/browse/AURORA-1002
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Patch ResourceManager into OSS Aurora.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 0434c7ba480a80a9722e626775cf5c3adbc3e68e 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
>   src/main/python/apache/aurora/executor/common/BUILD 142ec0d42b2cb31dcef1e32768e9ea5286355913 
>   src/main/python/apache/aurora/executor/common/resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/BUILD 2bf6b2df4761acaa88c38868f03e686ec6b42ab7 
>   src/test/python/apache/aurora/executor/common/test_resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29828/diff/
> 
> 
> Testing
> -------
> 
> Ran e2e v1 tests which broke, but not because of the RM wiring.  Running e2e2 tests now.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29828/
-----------------------------------------------------------

(Updated Jan. 13, 2015, 12:09 a.m.)


Review request for Aurora, Joshua Cohen and Kevin Sweeney.


Changes
-------

Add TODO


Bugs: AURORA-1002
    https://issues.apache.org/jira/browse/AURORA-1002


Repository: aurora


Description
-------

Patch ResourceManager into OSS Aurora.


Diffs (updated)
-----

  src/main/python/apache/aurora/executor/bin/BUILD 0434c7ba480a80a9722e626775cf5c3adbc3e68e 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
  src/main/python/apache/aurora/executor/common/BUILD 142ec0d42b2cb31dcef1e32768e9ea5286355913 
  src/main/python/apache/aurora/executor/common/resource_manager.py PRE-CREATION 
  src/test/python/apache/aurora/executor/common/BUILD 2bf6b2df4761acaa88c38868f03e686ec6b42ab7 
  src/test/python/apache/aurora/executor/common/test_resource_manager.py PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py PRE-CREATION 

Diff: https://reviews.apache.org/r/29828/diff/


Testing
-------

Ran e2e v1 tests which broke, but not because of the RM wiring.  Running e2e2 tests now.


Thanks,

Brian Wickman


Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29828/
-----------------------------------------------------------

(Updated Jan. 12, 2015, 11:40 p.m.)


Review request for Aurora, Joshua Cohen and Kevin Sweeney.


Changes
-------

Address jcohen


Bugs: AURORA-1002
    https://issues.apache.org/jira/browse/AURORA-1002


Repository: aurora


Description
-------

Patch ResourceManager into OSS Aurora.


Diffs (updated)
-----

  src/main/python/apache/aurora/executor/bin/BUILD 0434c7ba480a80a9722e626775cf5c3adbc3e68e 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
  src/main/python/apache/aurora/executor/common/BUILD 142ec0d42b2cb31dcef1e32768e9ea5286355913 
  src/main/python/apache/aurora/executor/common/resource_manager.py PRE-CREATION 
  src/test/python/apache/aurora/executor/common/BUILD 2bf6b2df4761acaa88c38868f03e686ec6b42ab7 
  src/test/python/apache/aurora/executor/common/test_resource_manager.py PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py PRE-CREATION 

Diff: https://reviews.apache.org/r/29828/diff/


Testing
-------

Ran e2e v1 tests which broke, but not because of the RM wiring.  Running e2e2 tests now.


Thanks,

Brian Wickman


Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

Posted by Brian Wickman <wi...@apache.org>.

> On Jan. 12, 2015, 11:35 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 100
> > <https://reviews.apache.org/r/29828/diff/1/?file=818229#file818229line100>
> >
> >     nit: should this be 2 spaces, not 4?

indentation is 2, continuations are typically 4.


> On Jan. 12, 2015, 11:35 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/executor/common/resource_manager.py, line 1
> > <https://reviews.apache.org/r/29828/diff/1/?file=818231#file818231line1>
> >
> >     Add license header to all these new files.

done


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29828/#review67744
-----------------------------------------------------------


On Jan. 12, 2015, 11:25 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29828/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 11:25 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1002
>     https://issues.apache.org/jira/browse/AURORA-1002
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Patch ResourceManager into OSS Aurora.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 0434c7ba480a80a9722e626775cf5c3adbc3e68e 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
>   src/main/python/apache/aurora/executor/common/BUILD 142ec0d42b2cb31dcef1e32768e9ea5286355913 
>   src/main/python/apache/aurora/executor/common/resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/BUILD 2bf6b2df4761acaa88c38868f03e686ec6b42ab7 
>   src/test/python/apache/aurora/executor/common/test_resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29828/diff/
> 
> 
> Testing
> -------
> 
> Ran e2e v1 tests which broke, but not because of the RM wiring.  Running e2e2 tests now.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29828/#review67744
-----------------------------------------------------------



src/main/python/apache/aurora/executor/bin/thermos_executor_main.py
<https://reviews.apache.org/r/29828/#comment111832>

    nit: should this be 2 spaces, not 4?



src/main/python/apache/aurora/executor/common/resource_manager.py
<https://reviews.apache.org/r/29828/#comment111831>

    Add license header to all these new files.


- Joshua Cohen


On Jan. 12, 2015, 11:25 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29828/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 11:25 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1002
>     https://issues.apache.org/jira/browse/AURORA-1002
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Patch ResourceManager into OSS Aurora.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 0434c7ba480a80a9722e626775cf5c3adbc3e68e 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
>   src/main/python/apache/aurora/executor/common/BUILD 142ec0d42b2cb31dcef1e32768e9ea5286355913 
>   src/main/python/apache/aurora/executor/common/resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/BUILD 2bf6b2df4761acaa88c38868f03e686ec6b42ab7 
>   src/test/python/apache/aurora/executor/common/test_resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29828/diff/
> 
> 
> Testing
> -------
> 
> Ran e2e v1 tests which broke, but not because of the RM wiring.  Running e2e2 tests now.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

Posted by Brian Wickman <wi...@apache.org>.

> On Jan. 12, 2015, 11:33 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/executor/common/resource_manager.py, lines 24-25
> > <https://reviews.apache.org/r/29828/diff/1/?file=818231#file818231line24>
> >
> >     Mind adding a TODO to drop the cpu and ram portions of this? Those are enforced by mesos.
> 
> Brian Wickman wrote:
>     They're here for cpu_percent and ram_percent to be exported.  Does the mesos slave export usage stats relative to reservation?
> 
> Kevin Sweeney wrote:
>     It doesn't, though it does export the raw metrics that make it possible. See https://issues.apache.org/jira/browse/MESOS-1458 for a discussion on why friendlier numbers are not exported.

OK then I'm inclined to keep them here for now.  Will add a TODO referencing MESOS-1458 which we can then delete if MESOS-1458 is closed wontfix.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29828/#review67743
-----------------------------------------------------------


On Jan. 12, 2015, 11:40 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29828/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 11:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1002
>     https://issues.apache.org/jira/browse/AURORA-1002
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Patch ResourceManager into OSS Aurora.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 0434c7ba480a80a9722e626775cf5c3adbc3e68e 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
>   src/main/python/apache/aurora/executor/common/BUILD 142ec0d42b2cb31dcef1e32768e9ea5286355913 
>   src/main/python/apache/aurora/executor/common/resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/BUILD 2bf6b2df4761acaa88c38868f03e686ec6b42ab7 
>   src/test/python/apache/aurora/executor/common/test_resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29828/diff/
> 
> 
> Testing
> -------
> 
> Ran e2e v1 tests which broke, but not because of the RM wiring.  Running e2e2 tests now.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

Posted by Brian Wickman <wi...@apache.org>.

> On Jan. 12, 2015, 11:33 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/executor/common/resource_manager.py, lines 24-25
> > <https://reviews.apache.org/r/29828/diff/1/?file=818231#file818231line24>
> >
> >     Mind adding a TODO to drop the cpu and ram portions of this? Those are enforced by mesos.

They're here for cpu_percent and ram_percent to be exported.  Does the mesos slave export usage stats relative to reservation?


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29828/#review67743
-----------------------------------------------------------


On Jan. 12, 2015, 11:25 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29828/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 11:25 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1002
>     https://issues.apache.org/jira/browse/AURORA-1002
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Patch ResourceManager into OSS Aurora.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 0434c7ba480a80a9722e626775cf5c3adbc3e68e 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
>   src/main/python/apache/aurora/executor/common/BUILD 142ec0d42b2cb31dcef1e32768e9ea5286355913 
>   src/main/python/apache/aurora/executor/common/resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/BUILD 2bf6b2df4761acaa88c38868f03e686ec6b42ab7 
>   src/test/python/apache/aurora/executor/common/test_resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29828/diff/
> 
> 
> Testing
> -------
> 
> Ran e2e v1 tests which broke, but not because of the RM wiring.  Running e2e2 tests now.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

Posted by Kevin Sweeney <ke...@apache.org>.

> On Jan. 12, 2015, 3:33 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/executor/common/resource_manager.py, lines 24-25
> > <https://reviews.apache.org/r/29828/diff/1/?file=818231#file818231line24>
> >
> >     Mind adding a TODO to drop the cpu and ram portions of this? Those are enforced by mesos.
> 
> Brian Wickman wrote:
>     They're here for cpu_percent and ram_percent to be exported.  Does the mesos slave export usage stats relative to reservation?

It doesn't, though it does export the raw metrics that make it possible. See https://issues.apache.org/jira/browse/MESOS-1458 for a discussion on why friendlier numbers are not exported.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29828/#review67743
-----------------------------------------------------------


On Jan. 12, 2015, 3:40 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29828/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 3:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1002
>     https://issues.apache.org/jira/browse/AURORA-1002
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Patch ResourceManager into OSS Aurora.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 0434c7ba480a80a9722e626775cf5c3adbc3e68e 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
>   src/main/python/apache/aurora/executor/common/BUILD 142ec0d42b2cb31dcef1e32768e9ea5286355913 
>   src/main/python/apache/aurora/executor/common/resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/BUILD 2bf6b2df4761acaa88c38868f03e686ec6b42ab7 
>   src/test/python/apache/aurora/executor/common/test_resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29828/diff/
> 
> 
> Testing
> -------
> 
> Ran e2e v1 tests which broke, but not because of the RM wiring.  Running e2e2 tests now.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29828/#review67743
-----------------------------------------------------------

Ship it!



src/main/python/apache/aurora/executor/common/resource_manager.py
<https://reviews.apache.org/r/29828/#comment111830>

    Mind adding a TODO to drop the cpu and ram portions of this? Those are enforced by mesos.


- Kevin Sweeney


On Jan. 12, 2015, 3:25 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29828/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 3:25 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1002
>     https://issues.apache.org/jira/browse/AURORA-1002
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Patch ResourceManager into OSS Aurora.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 0434c7ba480a80a9722e626775cf5c3adbc3e68e 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
>   src/main/python/apache/aurora/executor/common/BUILD 142ec0d42b2cb31dcef1e32768e9ea5286355913 
>   src/main/python/apache/aurora/executor/common/resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/BUILD 2bf6b2df4761acaa88c38868f03e686ec6b42ab7 
>   src/test/python/apache/aurora/executor/common/test_resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29828/diff/
> 
> 
> Testing
> -------
> 
> Ran e2e v1 tests which broke, but not because of the RM wiring.  Running e2e2 tests now.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>