You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gobblin.apache.org by hu...@apache.org on 2018/09/25 17:33:18 UTC
incubator-gobblin git commit: [GOBBLIN-592] Allow disabling
file-based failure reporting through config
Repository: incubator-gobblin
Updated Branches:
refs/heads/master 27655c41a -> acb90d71a
[GOBBLIN-592] Allow disabling file-based failure reporting through config
[GOBBLIN-592] Allow disabling file-based failure
reporting through config
[GOBBLIN-592]: Retrigger test
Closes #2460 from shardulm94/gobblin-592
Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/acb90d71
Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/acb90d71
Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/acb90d71
Branch: refs/heads/master
Commit: acb90d71a4e075afd19d704c69cb38bf9087c55a
Parents: 27655c4
Author: Shardul Mahadik <sm...@linkedin.com>
Authored: Tue Sep 25 10:33:12 2018 -0700
Committer: Hung Tran <hu...@linkedin.com>
Committed: Tue Sep 25 10:33:12 2018 -0700
----------------------------------------------------------------------
.../org/apache/gobblin/configuration/ConfigurationKeys.java | 2 ++
.../main/java/org/apache/gobblin/metrics/GobblinMetrics.java | 6 ++++++
2 files changed, 8 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/acb90d71/gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
----------------------------------------------------------------------
diff --git a/gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java b/gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
index 35a3a45..1e70209 100644
--- a/gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
+++ b/gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
@@ -658,6 +658,8 @@ public class ConfigurationKeys {
public static final String METRICS_LOG_DIR_KEY = METRICS_CONFIGURATIONS_PREFIX + "log.dir";
public static final String METRICS_FILE_SUFFIX = METRICS_CONFIGURATIONS_PREFIX + "reporting.file.suffix";
public static final String DEFAULT_METRICS_FILE_SUFFIX = "";
+ public static final String FAILURE_REPORTING_FILE_ENABLED_KEY = "failure.reporting.file.enabled";
+ public static final String DEFAULT_FAILURE_REPORTING_FILE_ENABLED = Boolean.toString(true);
public static final String FAILURE_LOG_DIR_KEY = "failure.log.dir";
// JMX-based reporting
http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/acb90d71/gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/GobblinMetrics.java
----------------------------------------------------------------------
diff --git a/gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/GobblinMetrics.java b/gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/GobblinMetrics.java
index 510f066..b986cda 100644
--- a/gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/GobblinMetrics.java
+++ b/gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/GobblinMetrics.java
@@ -524,6 +524,12 @@ public class GobblinMetrics {
}
private void buildFileFailureEventReporter(Properties properties) {
+ if (!Boolean.valueOf(properties.getProperty(ConfigurationKeys.FAILURE_REPORTING_FILE_ENABLED_KEY,
+ ConfigurationKeys.DEFAULT_FAILURE_REPORTING_FILE_ENABLED))) {
+ return;
+ }
+ LOGGER.info("Reporting failure to log files");
+
if (!properties.containsKey(ConfigurationKeys.FAILURE_LOG_DIR_KEY)) {
LOGGER.error(
"Not reporting failure to log files because " + ConfigurationKeys.FAILURE_LOG_DIR_KEY + " is undefined");