You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/05 07:51:33 UTC
Review Request 69895: Made SLRP `PublishResources` test to check
persistent volume cleanup.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69895/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-9544
https://issues.apache.org/jira/browse/MESOS-9544
Repository: mesos
Description
-------
This patch renames the `ROOT_PublishResources` test to
`ROOT_CreateDestroyPersistentMountVolume` and makes it verify that the
persistent volume is cleaned up after `DESTROY`.
Diffs
-----
src/tests/storage_local_resource_provider_tests.cpp e8ed20f818ed7f1a3ce15758ea3c366520443377
Diff: https://reviews.apache.org/r/69895/diff/1/
Testing
-------
`make check`
Thanks,
Chun-Hung Hsiao
Re: Review Request 69895: Made SLRP `PublishResources` test to check
persistent volume cleanup.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69895/
-----------------------------------------------------------
(Updated Feb. 28, 2019, 12:18 a.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Removed unnecessary filters.
Bugs: MESOS-9565
https://issues.apache.org/jira/browse/MESOS-9565
Repository: mesos
Description
-------
This patch renames the `ROOT_PublishResources` test to
`ROOT_CreateDestroyPersistentMountVolume` and makes it verify that the
persistent volume is cleaned up after `DESTROY`.
NOTE: The `filesystem/linux` isolator has been removed from the test
because it is not necessary for the test. However, the root privilege is
still required by the test CSI plugin for bind-mounting.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp a661951a0a326cc342aa0c45dd0967692ae70941
Diff: https://reviews.apache.org/r/69895/diff/4/
Changes: https://reviews.apache.org/r/69895/diff/3-4/
Testing
-------
`make check`
Thanks,
Chun-Hung Hsiao
Re: Review Request 69895: Made SLRP `PublishResources` test to check
persistent volume cleanup.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69895/
-----------------------------------------------------------
(Updated Feb. 13, 2019, 9:19 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Addressed Benjamin's comments.
Bugs: MESOS-9565
https://issues.apache.org/jira/browse/MESOS-9565
Repository: mesos
Description (updated)
-------
This patch renames the `ROOT_PublishResources` test to
`ROOT_CreateDestroyPersistentMountVolume` and makes it verify that the
persistent volume is cleaned up after `DESTROY`.
NOTE: The `filesystem/linux` isolator has been removed from the test
because it is not necessary for the test. However, the root privilege is
still required by the test CSI plugin for bind-mounting.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
Diff: https://reviews.apache.org/r/69895/diff/3/
Changes: https://reviews.apache.org/r/69895/diff/2-3/
Testing
-------
`make check`
Thanks,
Chun-Hung Hsiao
Re: Review Request 69895: Made SLRP `PublishResources` test to check
persistent volume cleanup.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On Feb. 12, 2019, 2:21 p.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 1984-1985 (patched)
> > <https://reviews.apache.org/r/69895/diff/2/?file=2124908#file2124908line2034>
> >
> > It looks like we use offers for synchronization here. Using a status update like above seems clearer and closer to what we want to me.
We need to set up the offers expectation anyway to make gmock happy. I could add operation status checking through. WDYT?
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69895/#review212739
-----------------------------------------------------------
On Feb. 12, 2019, 5:20 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69895/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2019, 5:20 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9544
> https://issues.apache.org/jira/browse/MESOS-9544
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch renames the `ROOT_PublishResources` test to
> `ROOT_CreateDestroyPersistentMountVolume` and makes it verify that the
> persistent volume is cleaned up after `DESTROY`.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
>
>
> Diff: https://reviews.apache.org/r/69895/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 69895: Made SLRP `PublishResources` test to check
persistent volume cleanup.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69895/#review212739
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/storage_local_resource_provider_tests.cpp
Line 1799 (original)
<https://reviews.apache.org/r/69895/#comment298629>
This seems unrelated to anything in the commit message (but worthwhile).
src/tests/storage_local_resource_provider_tests.cpp
Lines 1974 (patched)
<https://reviews.apache.org/r/69895/#comment298630>
Either `CSI volume` here, or `MOUNT volume` below.
src/tests/storage_local_resource_provider_tests.cpp
Lines 1984-1985 (patched)
<https://reviews.apache.org/r/69895/#comment298631>
It looks like we use offers for synchronization here. Using a status update like above seems clearer and closer to what we want to me.
- Benjamin Bannier
On Feb. 12, 2019, 6:20 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69895/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2019, 6:20 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9544
> https://issues.apache.org/jira/browse/MESOS-9544
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch renames the `ROOT_PublishResources` test to
> `ROOT_CreateDestroyPersistentMountVolume` and makes it verify that the
> persistent volume is cleaned up after `DESTROY`.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
>
>
> Diff: https://reviews.apache.org/r/69895/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 69895: Made SLRP `PublishResources` test to check
persistent volume cleanup.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69895/
-----------------------------------------------------------
(Updated Feb. 12, 2019, 5:20 a.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Rebased.
Bugs: MESOS-9544
https://issues.apache.org/jira/browse/MESOS-9544
Repository: mesos
Description
-------
This patch renames the `ROOT_PublishResources` test to
`ROOT_CreateDestroyPersistentMountVolume` and makes it verify that the
persistent volume is cleaned up after `DESTROY`.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
Diff: https://reviews.apache.org/r/69895/diff/2/
Changes: https://reviews.apache.org/r/69895/diff/1-2/
Testing
-------
`make check`
Thanks,
Chun-Hung Hsiao