[GitHub] [beam] apilloud commented on a change in pull request #12596: [BEAM-10498] [WIP] Eliminate nullability errors from :sdks:java:extensions:sql:zetasql

[GitBox <gi...@apache.org>]

apilloud commented on a change in pull request #12596:
URL: https://github.com/apache/beam/pull/12596#discussion_r472324306



##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/test/TestBoundedTable.java
##########
@@ -91,7 +92,7 @@ public static TestBoundedTable of(final Schema type) {
    * )
    * }</pre>
    */
-  public TestBoundedTable addRows(Object... args) {
+  public TestBoundedTable addRows(@Nullable Object... args) {

Review comment:
       Yes, these are nullable.

##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/values/Row.java
##########
@@ -735,7 +735,7 @@ public Builder addValues(List<Object> values) {
       return this;
     }
 
-    public Builder addValues(Object... values) {
+    public Builder addValues(@Nullable Object... values) {

Review comment:
       Yes, these are nullable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org