You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/25 03:17:44 UTC
[GitHub] [cloudstack] utchoang opened a new pull request #4728: UI: add component was missing
utchoang opened a new pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728
### Description
Fixes https://github.com/apache/cloudstack/issues/4724
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
After fix:
- Autocomplex:
- Slider:
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-785718758
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-785548319
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-787742631
> @DaanHoogland During my testing I found the slider component was missing so I added it.
@utchoang , I didn't find the new slider yet, I expected it at the cpus in the instance creation wizard. Where should I look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-785719510
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-787762997
@DaanHoogland You can go to Instance -> Add instance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-785803727
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4728 (SL-JID-17)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-785775423
@utchoang the combobox looks fine but I am missing the slider from the vm create dialog in that ^^ buils. Am I looking in the wrong place?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-785718960
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-785798127
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-785722256
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4728 (SL-JID-16)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-787900714
ah, does it only work with the 'constrained' offering? (i tried 'unconstrained')
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-785857753
@DaanHoogland During my testing I found the slider component was missing so I added it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-785548038
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-785719018
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-785721613
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4728 (SL-JID-15)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-785549943
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4728 (JID-3843)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4728: UI: add component was missing
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4728:
URL: https://github.com/apache/cloudstack/pull/4728#issuecomment-785798425
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org