You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by "Phabricator (JIRA)" <ji...@apache.org> on 2013/08/11 19:02:49 UTC

[jira] [Commented] (HIVE-4226) Cleanup non-threadsafe code in Hive

    [ https://issues.apache.org/jira/browse/HIVE-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736340#comment-13736340 ] 

Phabricator commented on HIVE-4226:
-----------------------------------

brock has commented on the revision "HIVE-4226 [jira] Cleanup non-threadsafe code in Hive".

  minor comment

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:170 Can we tighten up the visibility? For example I believe this and the one below can be private.

REVISION DETAIL
  https://reviews.facebook.net/D11703

To: JIRA, tarball
Cc: brock

                
> Cleanup non-threadsafe code in Hive
> -----------------------------------
>
>                 Key: HIVE-4226
>                 URL: https://issues.apache.org/jira/browse/HIVE-4226
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Sivaramakrishnan Narayanan
>            Assignee: Sivaramakrishnan Narayanan
>         Attachments: HIVE-4226.1.patch.txt, HIVE-4226.2.patch.txt, HIVE-4226.D11703.1.patch
>
>
> There is some code in Hive that is not threadsafe. These usually bubble up as problems in Hive Server. This JIRA tracks fixing (hopefully, all) of these issues.
> Some context: we've implemented a multi-tenant (multiple dbs), multi-threaded hive server at Qubole (QHS) which is running in production for a couple of months now. As part of this effort, we've fixed a number of instances of non-threadsafe code. I'm looking to contribute this back to the community.
> Note that there is no new functionality here - just some better hygiene. If there are any stress tests that have revealed hive server bugs in the past, it will be great if they can be added to the jira.
> Also, this is my first attempt at contributing to Apache, so please forgive any mistakes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira