[GitHub] tzulitai commented on a change in pull request #6924: [FLINK-10600] Provide End-to-end test cases for modern Kafka connectors

[GitBox <gi...@apache.org>]

tzulitai commented on a change in pull request #6924: [FLINK-10600] Provide End-to-end test cases for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#discussion_r229659492
 
 

 ##########
 File path: flink-examples/flink-examples-streaming/pom.xml
 ##########
 @@ -60,6 +60,18 @@ under the License.
 			<groupId>org.apache.flink</groupId>
 			<artifactId>flink-connector-kafka-0.10_${scala.binary.version}</artifactId>
 			<version>${project.version}</version>
+			<exclusions>
 
 Review comment:
   I also think that the Kafka 2.0 example should be in a separate module.
   Take for example our Elasticsearch E2E tests: each version of the Elasticsearch job lives within its own module, so that we don't need to do any extra things with the dependency packaging.
   
   On the other hand, as you can see, the Elasticsearch jobs live under the `flink-end-to-end-tests` module.
   Perhaps it would make sense to do the same for Kafka, instead of relying on the released example jobs as we do right now? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services