[jira] [Comment Edited] (ZOOKEEPER-1122) "start" and "stop" commands are not present in zkServer.cmd

["Kok-Hoon Teo (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386839#comment-17386839 ] 

Kok-Hoon Teo edited comment on ZOOKEEPER-1122 at 7/25/21, 8:44 AM:
-------------------------------------------------------------------

Hi all,

Here's an improved version of zkServerStop.cmd that avoids "Error 1067: The process terminated unexpectedly"
{quote}{color:#172b4d}@echo off{color}
 {color:#172b4d}setlocal{color}
 {color:#172b4d}call "%~dp0zkEnv.cmd"{color}

{color:#172b4d}@REM escape back-slashes for wmic query{color}
 {color:#172b4d}SET ZOOCFG_ESC=%ZOOCFG:\=\\%{color}
 {color:#172b4d}SET TMP_PID_FILE=java.pid{color}

{color:#172b4d}@REM query for java process with commandline containing %ZOOCFG%{color}
 {color:#172b4d}wmic process where 'commandline like "%%java.exe%%%ZOOCFG_ESC%%%"' get processid | findstr /r /c:"[0-9]" > %TMP_PID_FILE%{color}
 {color:#172b4d}FOR /F "tokens=*" %%F IN (%TMP_PID_FILE%) DO ({color}
 {color:#172b4d} @SET javaPID=%%F{color}
 {color:#172b4d}){color}

{color:#172b4d}if defined javaPID (taskkill /F /T /PID %javaPID%){color}

{color:#172b4d}del %TMP_PID_FILE%{color}
 {color:#172b4d}endlocal{color}
{quote}


was (Author: kokhoon):
Hi all,

Here's an improved version of zkServerStop.cmd that avoids "Error 1067: The process terminated unexpectedly"
{quote}{color:#172b4d}@echo off{color}
{color:#172b4d}setlocal{color}
{color:#172b4d}call "%~dp0zkEnv.cmd"{color}

{color:#172b4d}@REM escape back-slashes for wmic query{color}
{color:#172b4d}SET ZOOCFG_ESC=%ZOOCFG:\=\\%{color}
{color:#172b4d}SET TMP_PID_FILE=java.pid{color}

{color:#172b4d}@REM query for java process with commandline containing %ZOOCFG%{color}
{color:#172b4d}wmic process where 'commandline like "%%java.exe%%%ZOOCFG_ESC%%%"' get processid | findstr /r /c:"[0-9]" > %TMP_PID_FILE%{color}
{color:#172b4d}FOR /F "tokens=*" %%F IN (%TMP_PID_FILE%) DO ({color}
{color:#172b4d} @SET javaPID=%%F{color}
{color:#172b4d}){color}

{color:#172b4d}if defined javaPID (taskkill /F /T /PID %javaPID%){color}

{color:#172b4d}del %TMP_PID_FILE%{color}
{color:#172b4d}endlocal{color}
{quote}

> "start" and "stop" commands are not present in zkServer.cmd
> -----------------------------------------------------------
>
>                 Key: ZOOKEEPER-1122
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1122
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 3.3.3
>         Environment: Windows
>            Reporter: Alexander Osadchiy
>            Priority: Major
>              Labels: patch
>             Fix For: 3.8.0
>
>         Attachments: zkServer.cmd, zkServer.cmd
>
>
> Now ZooKeeper server can be started and stoped from Unix-based systems using script "bin/zkServer.sh":
> bin/zkServer.sh start - to start server;
> bin/zkServer.sh stop - to stop server.
> There are no "start" and "stop" commands in script "zkServer.cmd" (for Windows).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)